Skip to content

Conversation

@martinpucik
Copy link
Contributor

@martinpucik martinpucik commented May 5, 2022

What does this implement/fix? Explain your changes.

  • When inputBar's textView changes size, messagesCollectionView will update it's bottom content inset
  • If maintainPositionOnInputBarHeightChanged is set to false, content will scroll to bottom on textView height change to match iMessages behavior

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Devices/Simulators:

iOS Version:

Swift Version:

MessageKit Version:

Copy link
Member

@Kaspik Kaspik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

@martinpucik
Copy link
Contributor Author

Yup, I'm adding one, just needed the PR # 😂

@martinpucik martinpucik enabled auto-merge (squash) May 5, 2022 13:58
@martinpucik martinpucik merged commit 7d66a98 into 4.0.0 May 5, 2022
@martinpucik martinpucik deleted the input-bar-as-subview branch May 5, 2022 14:03
Patrick-Kladek pushed a commit to medbee/MessageKit that referenced this pull request Oct 25, 2023
…n inpuBar height change (MessageKit#1705)

* refactor: InpuBar height change behavior

* refactor: InpuBar height change behavior

Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants