fix: narrow bare except Exception to specific types where safe#54
Merged
Merged
Conversation
Replace broad except Exception with specific exception types in 6 sites where the expected failure mode is well-defined: - normalize.py: OSError for file read, ImportError for optional import - miner.py: OSError for file read_text - entity_detector.py: OSError for file read in scan loop - convo_miner.py: (OSError, ValueError) for normalize which reads and parses files - entity_registry.py: (URLError, OSError, JSONDecodeError, KeyError) for Wikipedia lookup fallback ChromaDB except Exception sites (~30) are left broad for now. chromadb.errors defines NotFoundError, DuplicateIDError, InvalidDimensionException etc., but narrowing those sites requires importing from chromadb.errors and validating across supported versions (>=0.4.0). MCP server handlers also left broad for resilience.
CuraIQ-Dev
pushed a commit
to Finimo-Solutions/mempalace-nexus-backend
that referenced
this pull request
Apr 21, 2026
…LOW + 2 CodeRabbit minor)
Adversarial R1 + CodeRabbit:
- HIGH (adv): where_document={'$contains': 'foo'} crashed _translate_where
(top-level $op rejected) making the keyword-boost path unreachable.
Fix: _normalize_where_document rewrites top-level {$contains: s} to
{content: {$contains: s}} before translation; _extract_keyword_text
still reads the original dict first so keyword_text is preserved.
- MED (adv): dikw_stage silently dropped on INSERT — listed in
_COLUMN_META_KEYS but missing from the INSERT column list. Fix: added
dikw_stage between source_id and entity in both base INSERT and
ON CONFLICT DO UPDATE SET.
- MED (adv): _connect leaked a Postgres connection when register_vector
raised (e.g. vector extension missing). Fix: try/except closes conn
on any BaseException before re-raising.
- LOW (adv + CodeRabbit MemPalace#173): $and + $or at the same node level, or a
logical op mixed with field keys, silently dropped one branch. Fix:
_translate_where.emit rejects both ambiguous shapes up front with
UnsupportedFilterError.
- LOW (adv): n_results unvalidated. Fix: positive-int guard at top of
query() raising ValueError.
- MINOR (CodeRabbit MemPalace#54): RECENCY_HALF_LIFE_SECONDS was a misnomer —
EXP(-Δt/T) is a 1/e time constant, not a half-life. Fix: renamed
constant to RECENCY_DECAY_SECONDS and updated the one SQL reference;
comment clarifies the formula shape. Behaviour unchanged.
- MINOR (CodeRabbit MemPalace#124): $contains ILIKE pattern f'%{arg}%' leaked %
and _ wildcards from user input (e.g. 'foo_bar' or '50%' acted as
wildcards). Fix: _escape_like helper escapes |, %, _ with | as the
escape char, paired with ESCAPE '|' in the SQL. Substring-only
semantics restored.
Simplify R1 2 LOW cosmetic findings remain accepted-non-blocking per
R1 justification (see code_review round_results).
File now 686 LOC (624 → 686, +62 for the 7 fixes). Under 750 cap.
Refs: specs/IMPL-AO-S301-T03-BACKENDS-NEXUS-001.yaml v0.2.0,
SPEC-KIRA-MEMPALACE-ADOPTION-001, SPEC-AGENT-BOOT-WAKE-UP-001.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace broad
except Exceptionwith specific exception types in 6 sites where the expected failure mode is well-defined:normalize.py:OSErrorfor file read,ImportErrorfor optional spellcheck importminer.py:OSErrorforfilepath.read_text()entity_detector.py:OSErrorfor file read in scan loopconvo_miner.py:(OSError, ValueError)fornormalize()which reads and parses filesentity_registry.py:(URLError, OSError, JSONDecodeError, KeyError)for Wikipedia lookup fallbackWhat's NOT changed (and why)
chromadb.errorsdefinesNotFoundError,DuplicateIDError,InvalidDimensionException, etc. (verified from source). Narrowing those sites requires importing fromchromadb.errorsand validating across supported versions (>=0.4.0) — left for a follow-up.file_already_minedchecks: ReturnFalseon any error is correct resilience behavior.Changes
5 files changed, 6 lines modified. Each
except Exceptionreplaced with the narrowest type(s) that cover the actual failure modes.Test plan
ruff checkpasses clean on all 5 filesruff format --checkalready formattedpython3 -m py_compilecompiles OK for all 5 filesOSErrorcovers all file I/O,ImportErrorcovers optional imports,urllib.error.URLErrorcovers network failures