test: expand coverage from 20 to 92 tests, migrate to uv by igorls · Pull Request #131 · MemPalace/mempalace

igorls · 2026-04-07T20:07:32Z

Summary

Expands the test suite from 20 → 92 tests covering previously untested modules, and migrates the project to uv for dependency management.

Test Coverage Added

File	Tests	Covers
`conftest.py`	—	Shared fixtures: isolated palace dirs, ChromaDB collections, KnowledgeGraph instances (all with guaranteed cleanup)
`test_knowledge_graph.py`	17	Entity CRUD, triple lifecycle, temporal queries (`as_of`), invalidation, timeline limits, stats
`test_mcp_server.py`	25	Protocol dispatch (initialize, tools/list, tools/call), read tools (status, list_wings, list_rooms, taxonomy), write tools (add/delete drawer, duplicate check), KG tools, diary tools
`test_searcher.py`	7	`search_memories` API: wing/room filters, result limits, error handling, response shape
`test_dialect.py`	13	AAAK compression, entity/emotion/topic detection, zettel encoding, decode roundtrip
(existing — unchanged)	20	config, miner, convo_miner, normalize

Tooling Changes

Build backend: setuptools → hatchling (lighter, uv-native)
Dev deps: Moved to [dependency-groups] (PEP 735) — pytest>=7.0, ruff>=0.4.0
Removed: requirements.txt (redundant with uv.lock)
Added: uv.lock for reproducible installs

Bug Fix (trivial)

Fixed __version__ mismatch: __init__.py said 2.0.0 while pyproject.toml said 3.0.0

How to run

uv sync --group dev
uv run pytest tests/ -v

All 92 tests pass on Python 3.13 with chromadb 0.6.3 (~16s).

Copilot

Pull request overview

This PR significantly expands the project’s test coverage (focused on the MCP server, search API, knowledge graph, and AAAK dialect) and updates packaging/tooling to use uv-friendly dependency management and hatchling, including aligning the library __version__ with pyproject.toml.

Changes:

Added new pytest suite + shared fixtures, increasing coverage across multiple previously untested modules.
Migrated packaging to hatchling and moved dev dependencies to [dependency-groups]; removed requirements.txt.
Fixed mempalace.__version__ mismatch.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/conftest.py	Adds shared fixtures for isolated palace and KG instances.
tests/test_searcher.py	Adds tests for programmatic `search_memories` API.
tests/test_mcp_server.py	Adds tool-handler and protocol dispatch tests for MCP server.
tests/test_knowledge_graph.py	Adds temporal KG tests (CRUD, temporal queries, invalidation, timeline, stats).
tests/test_dialect.py	Adds tests for AAAK dialect compression/encoding/decoding and helpers.
pyproject.toml	Switches build backend to hatchling and moves dev deps to dependency-groups.
requirements.txt	Removes legacy requirements file.
mempalace/init.py	Updates `__version__` to 3.0.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T20:11:52Z

+import chromadb
+


chromadb is imported but never used in this test module. With Ruff’s F rules enabled, this will be flagged as an unused import; please remove it (the fixtures already set up ChromaDB via seeded_collection).

Suggested change

import chromadb

Copilot · 2026-04-07T20:11:52Z

+def _patch_mcp_server(monkeypatch, config, palace_path, kg):
+    """Patch the mcp_server module globals to use test fixtures."""
+    from mempalace import mcp_server
+    import chromadb
+


Importing mempalace.mcp_server inside tests triggers module-level initialization (_kg = KnowledgeGraph()) which creates/initializes ~/.mempalace/knowledge_graph.sqlite3 on import. This means the test suite can write to a developer’s real home directory even though fixtures aim to isolate state; consider setting HOME (and/or patching mempalace.knowledge_graph.DEFAULT_KG_PATH) to a temp dir before importing the module, or reworking tests to import after applying such a patch.

Copilot · 2026-04-07T20:11:52Z

+import pytest
+
+


pytest is imported but not referenced anywhere in this file (fixtures don’t require an explicit import). With Ruff F401 enabled, this will be flagged as an unused import; please remove it.

Suggested change

import pytest

Copilot · 2026-04-07T20:11:53Z

+def _patch_mcp_server(monkeypatch, config, palace_path, kg):
+    """Patch the mcp_server module globals to use test fixtures."""
+    from mempalace import mcp_server
+    import chromadb
+
+    monkeypatch.setattr(mcp_server, "_config", config)
+    monkeypatch.setattr(mcp_server, "_kg", kg)
+
+


chromadb is imported inside _patch_mcp_server but not used, and the palace_path parameter is currently unused. This is dead code and (for the import) will be flagged by Ruff; please remove the unused import and either use or drop the unused parameter to keep the helper minimal and clear.

Copilot · 2026-04-07T20:11:53Z

+
+from mempalace.config import MempalaceConfig
+from mempalace.knowledge_graph import KnowledgeGraph
+
+


Tests currently don’t globally isolate ~/HOME. Since parts of the library (e.g., KnowledgeGraph() default path via os.path.expanduser('~/.mempalace/...')) can create files on import/use, consider adding an autouse=True fixture here that sets HOME (and Windows equivalents) to a temp dir for the duration of the test session to guarantee no writes to a real user profile.

Suggested change

from mempalace.config import MempalaceConfig

from mempalace.knowledge_graph import KnowledgeGraph

_TEST_HOME_DIR = tempfile.mkdtemp(prefix="mempalace_home_")

_ORIGINAL_HOME_ENV = {

"HOME": os.environ.get("HOME"),

"USERPROFILE": os.environ.get("USERPROFILE"),

"HOMEDRIVE": os.environ.get("HOMEDRIVE"),

"HOMEPATH": os.environ.get("HOMEPATH"),

}

os.environ["HOME"] = _TEST_HOME_DIR

os.environ["USERPROFILE"] = _TEST_HOME_DIR

drive, path = os.path.splitdrive(_TEST_HOME_DIR)

os.environ["HOMEDRIVE"] = drive or ""

os.environ["HOMEPATH"] = path or _TEST_HOME_DIR

from mempalace.config import MempalaceConfig

from mempalace.knowledge_graph import KnowledgeGraph

@pytest.fixture(scope="session", autouse=True)

def isolated_home_dir():

"""Redirect user-home expansion to a temp directory for the test session."""

yield _TEST_HOME_DIR

for env_name, original_value in _ORIGINAL_HOME_ENV.items():

if original_value is None:

os.environ.pop(env_name, None)

else:

os.environ[env_name] = original_value

shutil.rmtree(_TEST_HOME_DIR, ignore_errors=True)

Copilot · 2026-04-07T20:11:53Z

 [project.scripts]
 mempalace = "mempalace:main"

-[project.optional-dependencies]
-dev = ["pytest>=7.0", "build>=1.0", "twine>=4.0"]
+[dependency-groups]
+dev = ["pytest>=7.0", "ruff>=0.4.0"]
+
+[build-system]
+requires = ["hatchling"]
+build-backend = "hatchling.build"


Dropping [project.optional-dependencies].dev in favor of [dependency-groups].dev breaks the documented contributor install command pip install -e ".[dev]" (see CONTRIBUTING.md:10). Consider either updating the docs or keeping a dev extra (possibly mirroring the dependency-group) so non-uv workflows still work.

bensig · 2026-04-07T20:45:03Z

Hey Igor — CI is failing, looks like it needs a rebase on main (we've merged a bunch of changes recently). Can you rebase and push?

- Migrate from setuptools to hatchling build backend - Add dependency-groups (PEP 735) for dev tooling (pytest, ruff) - Remove redundant requirements.txt in favor of uv.lock - Fix __version__ mismatch (2.0.0 -> 3.0.0 to match pyproject.toml) New test files: - conftest.py: shared fixtures (isolated palace, KG, ChromaDB collection) - test_knowledge_graph.py: 17 tests (entity CRUD, temporal queries, timeline) - test_mcp_server.py: 25 tests (protocol dispatch, read/write/KG/diary tools) - test_searcher.py: 7 tests (search_memories API, filters, error handling) - test_dialect.py: 13 tests (AAAK compression, entity/emotion detection, zettel encoding) All 92 tests pass on Python 3.13 with chromadb 0.6.3.

…tests, restore dev extra

- Switch CI install step from `pip install -r requirements.txt` to `pip install -e ".[dev]"` since requirements.txt was removed - Add noqa: E402 to intentionally-late imports in conftest.py (HOME must be isolated before mempalace imports) - Remove unused KnowledgeGraph import in test_knowledge_graph.py - Apply ruff formatting to test files

igorls · 2026-04-07T21:00:15Z

CI should pass now

PR MemPalace#147 renamed compression_stats fields (ratio -> size_ratio, compressed_chars -> summary_chars) and switched count_tokens to a word-based heuristic, but the test_dialect tests from PR MemPalace#131 still assert the old API and fail on main. Bring TestCompressionStats.test_stats in line with the current dict keys (size_ratio, summary_chars, summary_tokens_est) and update test_count_tokens to match the word-based formula, with extra coverage for the empty and single-word edge cases around max(1, ...). This unblocks CI on main, which currently fails on these two tests.

Copilot AI review requested due to automatic review settings April 7, 2026 20:07

Copilot started reviewing on behalf of igorls April 7, 2026 20:08 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

igorls added 2 commits April 7, 2026 17:55

fix: address Copilot review — remove unused imports, isolate HOME in …

cd8b245

…tests, restore dev extra

igorls force-pushed the test/expand-coverage-and-uv-migration branch from 135d4c6 to cd8b245 Compare April 7, 2026 20:56

bensig merged commit 27623a3 into MemPalace:main Apr 7, 2026
4 checks passed

adv3nt3 mentioned this pull request Apr 7, 2026

test(dialect): strengthen compression_stats and count_tokens assertions #150

Closed

3 tasks

milla-jovovich mentioned this pull request Apr 9, 2026

chore: bump version to 3.1.0 #409

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: expand coverage from 20 to 92 tests, migrate to uv#131

test: expand coverage from 20 to 92 tests, migrate to uv#131
bensig merged 3 commits into
MemPalace:mainfrom
igorls:test/expand-coverage-and-uv-migration

igorls commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

bensig commented Apr 7, 2026

Uh oh!

igorls commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		from mempalace.config import MempalaceConfig
		from mempalace.knowledge_graph import KnowledgeGraph

-from mempalace.config import MempalaceConfig
-from mempalace.knowledge_graph import KnowledgeGraph
+_TEST_HOME_DIR = tempfile.mkdtemp(prefix="mempalace_home_")
+_ORIGINAL_HOME_ENV = {
+    "HOME": os.environ.get("HOME"),
+    "USERPROFILE": os.environ.get("USERPROFILE"),
+    "HOMEDRIVE": os.environ.get("HOMEDRIVE"),
+    "HOMEPATH": os.environ.get("HOMEPATH"),
+}
+os.environ["HOME"] = _TEST_HOME_DIR
+os.environ["USERPROFILE"] = _TEST_HOME_DIR
+drive, path = os.path.splitdrive(_TEST_HOME_DIR)
+os.environ["HOMEDRIVE"] = drive or ""
+os.environ["HOMEPATH"] = path or _TEST_HOME_DIR
+from mempalace.config import MempalaceConfig
+from mempalace.knowledge_graph import KnowledgeGraph
+@pytest.fixture(scope="session", autouse=True)
+def isolated_home_dir():
+    """Redirect user-home expansion to a temp directory for the test session."""
+    yield _TEST_HOME_DIR
+    for env_name, original_value in _ORIGINAL_HOME_ENV.items():
+        if original_value is None:
+            os.environ.pop(env_name, None)
+        else:
+            os.environ[env_name] = original_value
+    shutil.rmtree(_TEST_HOME_DIR, ignore_errors=True)

Conversation

igorls commented Apr 7, 2026

Summary

Test Coverage Added

Tooling Changes

Bug Fix (trivial)

How to run

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

bensig commented Apr 7, 2026

Uh oh!

igorls commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants