Skip to content

fix: harden Chroma status path and Windows CLI output#1124

Draft
vanachterjacob wants to merge 5 commits into
MemPalace:developfrom
vanachterjacob:codex/mempalace-fix-windows-help-and-status
Draft

fix: harden Chroma status path and Windows CLI output#1124
vanachterjacob wants to merge 5 commits into
MemPalace:developfrom
vanachterjacob:codex/mempalace-fix-windows-help-and-status

Conversation

@vanachterjacob

@vanachterjacob vanachterjacob commented Apr 23, 2026

Copy link
Copy Markdown

Summary

This PR fixes three user-facing failures I hit while verifying a local MemPalace install on Windows:

  • quarantine stale Chroma HNSW segment directories before opening a refreshed client
  • paginate mempalace status metadata reads so large palaces do not hit SQLite variable limits
  • make CLI help/status text ASCII-safe so default Windows cp1252 consoles do not crash on --help

Validation

  • python -m pytest tests/test_backends.py tests/test_cli.py tests/test_miner.py -q
  • python -m mempalace.cli --help
  • python -m mempalace.cli init --help
  • python -m mempalace.cli status

Fixes #1121
Fixes #1122
Fixes #1123

@igorls igorls added bug Something isn't working area/windows Windows-specific bugs and compatibility area/cli CLI commands labels Apr 24, 2026
@mjc mjc mentioned this pull request Apr 28, 2026
Closed
mjc added a commit to mjc/mempalace that referenced this pull request Apr 28, 2026
@mjc
Harden Chroma repair and startup preflight
8d3234e 
Follow-up to MemPalace#1222.
Directly related to MemPalace#1124.
Adjacent to the upstream HNSW index-bloat work in MemPalace#1191.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mjc added a commit to mjc/mempalace that referenced this pull request Apr 28, 2026
@mjc
Harden Chroma repair and startup preflight
946c49d 
Follow-up to MemPalace#1222.
Directly related to MemPalace#1124.
Adjacent to the upstream HNSW index-bloat work in MemPalace#1191.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mjc added a commit to mjc/mempalace that referenced this pull request Apr 28, 2026
@mjc
Harden Chroma repair and startup preflight
c7e7819 
Follow-up to MemPalace#1222.
Directly related to MemPalace#1124.
Adjacent to the upstream HNSW index-bloat work in MemPalace#1191.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mjc added a commit to mjc/mempalace that referenced this pull request Apr 28, 2026
@mjc
Harden Chroma repair and startup preflight
74cf1e5 
Follow-up to MemPalace#1222.
Directly related to MemPalace#1124.
Adjacent to the upstream HNSW index-bloat work in MemPalace#1191.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mjc added a commit to mjc/mempalace that referenced this pull request Apr 28, 2026
@mjc
Harden Chroma repair and startup preflight
94e5301 
Follow-up to MemPalace#1222.
Directly related to MemPalace#1124.
Adjacent to the upstream HNSW index-bloat work in MemPalace#1191.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mjc mjc mentioned this pull request Apr 30, 2026
Merged
@igorls

igorls commented May 3, 2026

Copy link
Copy Markdown
Member

Hi @Aaron-trinity — this PR is currently DRAFT, +3180/-3104, CONFLICTING, and bundles three unrelated fixes (HNSW segment quarantine, status pagination, Windows CLI ASCII).

The status pagination part is already shipped on develop via mcp_server.py:_fetch_all_metadata and miner.py:status pagination (issues #1098/#1073/#1123 closed as fixed). The Windows ASCII piece is now being handled by #1282.

The remaining valuable piece is the HNSW segment quarantine for _client() — that's the only path not covered by the merged #1173 (which only wired make_client()). It maps to issue #1121 (now in v3.3.5).

Could you split the quarantine fix into its own focused PR against current develop? Or, if you'd rather hand it off, comment here and we'll write the minimal patch ourselves and credit you. The remaining diff for that piece should be ~5-10 lines (extend _client() to call quarantine_stale_hnsw like make_client() already does).

@igorls igorls changed the base branch from main to develop May 17, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milla-jovovich milla-jovovich Awaiting requested review from milla-jovovich milla-jovovich will be requested when the pull request is marked ready for review milla-jovovich is a code owner

@igorls igorls Awaiting requested review from igorls igorls will be requested when the pull request is marked ready for review igorls is a code owner

Assignees

No one assigned

Labels

area/cli CLI commands area/windows Windows-specific bugs and compatibility bug Something isn't working

Projects

None yet

Milestone

No milestone

2 participants

@vanachterjacob @igorls