[State] Feat: Added Remote backend option for S3, GCS and Azblob#10
Merged
[State] Feat: Added Remote backend option for S3, GCS and Azblob#10
Conversation
MeNsaaH
requested changes
Jan 17, 2021
Owner
MeNsaaH
left a comment
There was a problem hiding this comment.
This looks like a generic implementation for all cloud providers, correct? So, aws S3, gcs and Azure Blob Storage should work just fine yeah?
NICEEE
state/backend.go
Outdated
| switch cfg.StateBackend.Type { | ||
| s := NewEmptyState() | ||
| switch { | ||
| case config.Contains(config.StateBackendTypes[1:], cfg.StateBackend.Type): |
Owner
There was a problem hiding this comment.
Could we reference the RemoteBackendTypes from here, instead of using indexes. It could get messy and difficult to debug
deven96
commented
Jan 17, 2021
Collaborator
Author
deven96
left a comment
There was a problem hiding this comment.
This looks like a generic implementation for all cloud providers, correct? So, aws S3, gcs and Azure Blob Storage should work just fine yeah?
NICEEE
Yeah the gocloud library handles storage consistency across cloud providers perfectly, we might like to do something similar for python
MeNsaaH
pushed a commit
that referenced
this pull request
Apr 5, 2022
MeNsaaH
pushed a commit
that referenced
this pull request
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fix for #4