Skip to content

Conversation

@JLdgu
Copy link
Contributor

@JLdgu JLdgu commented Jul 4, 2024

Both changes are to Demo projects

@Keboo
Copy link
Member

Keboo commented Jul 11, 2024

Hey @JLdgu, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #3624

#3624

I would set the default namespace for the shared project. So that the analyzer doesn't flag the files as not matching the project name.

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@JLdgu
Copy link
Contributor Author

JLdgu commented Jul 12, 2024

@Keboo On Discord I asked whether the namespace of the shared project should be MaterialDesignDemo.Shared in order to explicitly highlight shared code. @michaelmairegger said it should.
If you want me to change the namespace should I included it in this PR or have this one merged and raise a new PR?

@Keboo
Copy link
Member

Keboo commented Jul 12, 2024

@Keboo On Discord I asked whether the namespace of the shared project should be MaterialDesignDemo.Shared in order to explicitly highlight shared code. @michaelmairegger said it should. If you want me to change the namespace should I included it in this PR or have this one merged and raise a new PR?

ah sorry, I have been in the process of moving and have kept up. I am fine with it being a separate PR so we can get this one in.

@Keboo Keboo enabled auto-merge (squash) July 12, 2024 17:56
@Keboo Keboo added this to the 5.2.0 milestone Jul 12, 2024
@Keboo Keboo added the demo app Items that relate to the demo application label Jul 12, 2024
@Keboo Keboo merged commit 5438e9c into MaterialDesignInXAML:master Jul 12, 2024
@JLdgu JLdgu deleted the sharedCode branch July 15, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

demo app Items that relate to the demo application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants