fix: route manual/overflow compaction through compact() wrapper#298
Merged
jalehman merged 1 commit intoMartian-Engineering:mainfrom Apr 6, 2026
Conversation
engine.ts called compaction.compactFullSweep() directly for manual and overflow compaction paths, bypassing the compact() method. Once PR Martian-Engineering#295 adds the withContextCache wrapper to compact(), this direct call would miss the per-phase context cache optimization. Change: compactFullSweep → compact (same signature, same behavior, but goes through the wrapper that future PRs will enhance). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Routes manual and overflow compaction through the CompactionEngine.compact() wrapper so future wrapper-only optimizations (e.g., context cache from #295) apply consistently across compaction entry points.
Changes:
- Replace direct call to
compaction.compactFullSweep()withcompaction.compact()for the sweep path inengine.ts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix:
engine.tscalledcompaction.compactFullSweep()directly for manual and overflow compaction, bypassing thecompact()method. This means the context cache optimization from PR #295 would not apply to manual/compactor overflow recovery paths.Merge order: between #294 and #289 (touches engine.ts only, no conflicts with any other PR).
Part of the LCM Performance & Cache Optimization Sprint — see #297.
Change
compact()delegates tocompactFullSweep()with the same signature. Currently identical behavior, but once #295 merges,compact()wraps withwithContextCachefor the read optimization.Test
🤖 Generated with Claude Code