Add multiple test site support#588
Merged
yamgent merged 4 commits intoMarkBind:masterfrom Jan 30, 2019
Merged
Conversation
0bb6ec4 to
60345eb
Compare
yamgent
requested changes
Jan 23, 2019
9acda71 to
67b5db4
Compare
Contributor
Author
|
Rebased, updated I placed all the |
yamgent
requested changes
Jan 23, 2019
Member
yamgent
left a comment
There was a problem hiding this comment.
I placed all the
test_siterelated changes in a separate commit, so you should just have to look at theAdd multiple test site functionalitycommit for review
Thanks a lot, that makes the reviewing process much easier. 👍
67b5db4 to
97bdcd3
Compare
Contributor
Author
|
Rebased, updated |
yamgent
approved these changes
Jan 26, 2019
Member
yamgent
left a comment
There was a problem hiding this comment.
LGTM. As you mention, you will remove test_site_2 right?
Contributor
Author
|
Yup, removed it |
f38593a to
ede3281
Compare
ede3281 to
ac11ce2
Compare
Contributor
Author
|
Rebased to fix conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [X] New feature
Fixes #574
What is the rationale for this request?
Some features, such as tagging, must be tested on different sites since the test cases are mutually exclusive.
What changes did you make? (Give an overview)
Allow support for any number of test sites.
Revamped test directory structure:
Creating a new test site:
test/functionalmarkbind initin the folder, write test site as per normalexpecteddirectory within the folder and populate with expected filestest.sh
test.bat
Note: Ensure
expecteddirectory is ignored (Addexpected/*to the site.json ignore), and that nosrcorglobmatches any of the expected files (the default glob**/*.+(md|mbd)causes some problems)Is there anything you'd like reviewers to focus on?
The current
test_site_2folder is just there to show the feature works, it stores a fresh init site. Will remove before merge. No edits made to test_site, except for removing 3 lines from the site.jsonHow do we want to organize the tests? For example, say we have:
We could do something like this: