Make the project compile and pass tests under net6.0 #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuDR
reviewed
Jan 13, 2022
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFrameworks>netcoreapp3.1;net5.0</TargetFrameworks> | ||
| <TargetFrameworks>net6.0</TargetFrameworks> |
There was a problem hiding this comment.
Suggested change
| <TargetFrameworks>net6.0</TargetFrameworks> | |
| <TargetFramework>net6.0</TargetFramework> |
Contributor
Author
There was a problem hiding this comment.
These are not the only changes in the pull request.
Search the code for NET6_0_OR_GREATER.
There is some define that was not including code for net6.0
Contributor
|
Hi @Philippe-Laval, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I managed to have the Maspter project compile under net6.0 and pass all the unit tests.
I had to add some #if NET6_0_OR_GREATER in the source code.
I created also a project "TemplateTest" to show how to generate code (the T4 templates in the project "Benchmark" are not working, so I had to comment some unit tests for now and take the code of T4 template to the unit tests).
I guess, we could