refactor: unify Overseerr and Jellyseerr into single Seerr abstraction#2397
Merged
Conversation
Collaborator
Author
|
@ydkmlt84 This is ready now. Once we merge jellyfin-dev to main, I'll change the base here to main instead, and you can review/merge/whatever. |
71b15e0 to
f885af6
Compare
Consolidate the separate Overseerr and Jellyseerr integrations into a single 'Seerr' abstraction. Both Overseerr and Jellyseerr are forks of the same project with identical APIs, so maintaining two parallel implementations was unnecessary duplication. Changes: - Merge OverseerrApiService + JellyseerrApiService into SeerrApiService - Merge OverseerrGetterService + JellyseerrGetterService into SeerrGetterService - Merge Overseerr + Jellyseerr UI settings components into single Seerr component - Rename DB columns: overseerr_url/overseerr_api_key -> seerr_url/seerr_api_key - Rename DB column: forceOverseerr -> forceSeerr on collection table - Drop jellyseerr_url/jellyseerr_api_key columns (redundant after merge) - Remove Application.JELLYSEERR (5) enum value; Application.SEERR (3) covers both - Unify cache IDs from separate overseerr/jellyseerr entries to single seerr entry - Remove duplicate JELLYSEERR rule constants (identical props to OVERSEERR) Data migration (automatic on upgrade): - Settings: COALESCE(overseerr_url, jellyseerr_url) -> seerr_url (and api_key) - Rules: ruleJson firstVal/lastVal app ID 5 (JELLYSEERR) rewritten to 3 (SEERR) - Collection: forceOverseerr values preserved as forceSeerr Backward-compatible API route aliases retained for /overseerr and /jellyseerr endpoints so existing consumers are not broken. Net result: -1130 lines of code, zero duplicated logic.
The hand-written migration was missing the totalSizeBytes column in the collection table recreation, causing a fatal crash after migration. Regenerated with TypeORM and preserved manual COALESCE data migration for overseerr/jellyseerr → seerr and ruleJson REPLACE for enum values.
c5ab643 to
8187296
Compare
enoch85
added a commit
to enoch85/Maintainerr
that referenced
this pull request
Feb 28, 2026
…ndling branch Resolve conflicts from the Seerr migration (PR Maintainerr#2397) which unified Overseerr and Jellyseerr into a single Seerr abstraction. Accept deletions of old Jellyseerr-specific files, carry over connection-test utilities to the unified Seerr service, and preserve parallel test execution in settings.
Contributor
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unifies the separate Overseerr and Jellyseerr integrations into a single Seerr abstraction. They are forks of the same project with identical APIs — maintaining two parallel implementations was unnecessary duplication.
What changed
seerr-*equivalentsoverseerr_url→seerr_url,forceOverseerr→forceSeerr, etc.)Application.JELLYSEERRenum value;Application.SEERRcovers bothMigration
Fully automatic — no user action required:
COALESCE(overseerr_url, jellyseerr_url)→seerr_url5(Jellyseerr) rewritten to3(Seerr)forceOverseerrvalues preserved asforceSeerrBackward compatibility
API route aliases for
/overseerrand/jellyseerrendpoints are retained so existing consumers are not broken.