feat: Add smart collection filters#1630
Merged
Merged
Conversation
Smart collections are not returned in the metadata Collection array. Instead we must iterate over each smart collection, load its children and then check if the rating key is present.
Member
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
enoch85
added a commit
that referenced
this pull request
May 24, 2026
…antics uniqueTrimmedRulePropertyNames now de-duplicates on the raw value and trims afterwards (Array.from(new Set(names)).map(trim)) — exactly the development behaviour from #1630. The earlier trim-then-dedupe collapsed whitespace/case variants into one entry, which is a user-visible change for the COUNT_* comparators on the *_including_smart TEXT_LIST rules (ids 41/42). Specs updated to lock the restored behaviour.
enoch85
added a commit
that referenced
this pull request
May 25, 2026
…ev mocks/seed - uniqueTrimmedRulePropertyNames de-duplicates on the raw value, then trims, exactly matching the pre-refactor Plex behaviour from #1630 for the *_including_smart TEXT_LIST rules (ids 41/42). Titles differing only by surrounding whitespace or capitalization stay separate, which the COUNT_* comparators depend on. Specs updated to lock it. - dev/fake-plex.mjs: stateless mock Plex (peer to dev/fake-jellyfin.mjs) covering the Plex-only getter paths. - dev/seed-db.mjs: seeds rule groups with rules across the property surface plus notifications, cron, logs, exclusions and overlays (MEDIA_SERVER=plex|jellyfin). - AGENTS.md: document the three dev scripts as a Playwright complement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 4 new rules:
These use the same logic as the existing non-smart collection rules, with the addition of checking smart collections.
Smart collections are not returned in the metadata Collection array. Instead we must iterate over each smart collection, load its children and then check if the rating key is present.
The rule IDs skip a few to cater for the ones added in PR #1627