Skip to content

Conversation

@KristjanESPERANTO
Copy link
Collaborator

Short description: I completed the translations with the help of translation tools.

Long description: I'm currently looking at the translation-tests and I noticed the e2e-test ${language} should contain all base keys, (). It is supposed to check whether all keys are present in each translation file, but it doesn't actually work that way. When I fix it, a lot of missing translations are reported. I have completed these translations with the help of translation tools and packed them into this PR. I have left out the modified test so that we can focus on the question if we accept such amount of automatic translations or not.

rejas has already expressed in another PR (#3775 (comment)) that he prefers human translators. I basically do too, but I don't see how we can manage to have all translations completed by humans. And even if a few translations are not correct, hopefully a user will get in touch.

If we decide against the translations, we should at least remove the test. If we go for the tranlsations, I'll add the test.

What do you think?

@sdetweil
Copy link
Collaborator

I think it's better to have the translations and take PRs for being wrong. This is such a small space of technical terms, most automated would be right.

I did the same on a product years ago and only had one correction in the Korean translation

@khassel
Copy link
Collaborator

khassel commented May 28, 2025

go for translations

@rejas
Copy link
Collaborator

rejas commented May 29, 2025

I am still sceptic... Could you ask in the forums for people that can check this PR?

@KristjanESPERANTO KristjanESPERANTO changed the title Complete translations [l10n] Complete translations May 29, 2025
@khassel
Copy link
Collaborator

khassel commented May 29, 2025

@rejas as you are active here, can you please read discord and change the permissions needed, thanks.

@khassel
Copy link
Collaborator

khassel commented May 29, 2025

I am still sceptic... Could you ask in the forums for people that can check this PR?

To be honest, I'm not expecting any feedback, so I see it as a waste of time. We can do it and wait for reactions, but the PR should be merged before the next release.

@KristjanESPERANTO
Copy link
Collaborator Author

KristjanESPERANTO commented May 29, 2025

I am still sceptic... Could you ask in the forums for people that can check this PR?

Since we still have some time until the next release, I think it's okay to ask the community for help: https://forum.magicmirror.builders/topic/19709/community-task-check-automated-translations 🙂

@KristjanESPERANTO
Copy link
Collaborator Author

I suggest that if there is no feedback from the forum by Monday we merge this.

@sdetweil
Copy link
Collaborator

The forums have been pretty quiet for a month now. I wouldn't expect much activity on this by Monday

@bugsounet
Copy link
Contributor

@KristjanESPERANTO :

There is nothing to review in fr.json file ?
I don't see it in change files list

@KristjanESPERANTO
Copy link
Collaborator Author

There is nothing to review in fr.json file ?

Yes, that's right. This translation was already complete, so I didn't have to touch it.

KristjanESPERANTO and others added 2 commits June 4, 2025 00:33
Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com>
Copy link
Collaborator

@rejas rejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so lets try this :-)

@rejas rejas merged commit 302b24c into MagicMirrorOrg:develop Jun 5, 2025
9 checks passed
@KristjanESPERANTO KristjanESPERANTO deleted the translations branch June 5, 2025 08:47
rejas pushed a commit that referenced this pull request Jun 9, 2025
…s" (#3809)

While working on the translations (in #3792 and #3794) I realised that
the e2e "Same keys" tests were not working entirely. There was also a
TODO entry for this in the test, as well as a try-catch-block
workaround. I therefore fixed and refactored it.

I also sorted the translations in `translations/translations.js`, so
that the test outputs are alphabetically.
@khassel khassel mentioned this pull request Jun 30, 2025
khassel added a commit that referenced this pull request Jun 30, 2025
## [2.32.0] - 2025-07-01

Thanks to: @bughaver, @bugsounet, @khassel, @KristjanESPERANTO,
@plebcity, @rejas, @sdetweil.

> ⚠️ This release needs nodejs version `v22.14.0 or higher`

### Added

- [config] Allow to change module order for final renderer (or
dynamically with CSS): Feature `order` in config (#3762)
- [clock] Added option 'disableNextEvent' to hide next sun event (#3769)
- [clock] Implement short syntax for clock week (#3775)

### Changed

- [refactor] Simplify module loading process (#3766)
- Use `node --run` instead of `npm run` (#3764) and adapt `start:dev`
script (#3773)
- [workflow] Run linter and spellcheck with LTS node version (#3767)
- [workflow] Split "Run test" step into two steps for more clarity
(#3767)
- [linter] Review linter setup (#3783)
  - Fix command to lint markdown in `CONTRIBUTING.md`
  - Re-activate JSDoc linting and fix linting issues
  - Refactor ESLint config to use `defineConfig` and `globalIgnores`
  - Replace `eslint-plugin-import` with `eslint-plugin-import-x`
- Switch Stylelint config to flat format and simplify Stylelint scripts
- [workflow] Replace Node.js version v23 with v24 (#3770)
- [refactor] Replace deprecated constants `fs.F_OK` and `fs.R_OK`
(#3789)
- [refactor] Replace `ansis` with built-in function `util.styleText`
(#3793)
- [core] Integrate stuff from `vendor` and `fonts` folders into main
`package.json`, simplifies install and maintaining dependencies (#3795,
#3805)
- [l10n] Complete translations (with the help of translation tools)
(#3794)
- [refactor] Refactored `calendarfetcherutils` in Calendar module to
handle timezones better (#3806)
  - Removed as many of the date conversions as possible
- Use `moment-timezone` when calculating recurring events, this will fix
problems from the past with offsets and DST not being handled properly
- Added some tests to test the behavior of the refactored methods to
make sure the correct event dates are returned
- [linter] Enable ESLint rule `no-console` and replace `console` with
`Log` in some files (#3810)
- [tests] Review and refactor translation tests (#3792)

### Fixed

- [fix] Handle spellcheck issues (#3783)
- [calendar] fix fullday event rrule until with timezone offset (#3781)
- [feat] Add rule `no-undef` in config file validation to fix #3785
(#3786)
- [fonts] Fix `roboto.css` to avoid error message `Unknown descriptor
'var(' in @font-face rule.` in firefox console (#3787)
- [tests] Fix and refactor e2e test `Same keys` in
`translations_spec.js` (#3809)
- [tests] Fix e2e tests newsfeed and calendar to exit without open
handles (#3817)

### Updated

- [core] Update dependencies including electron to v36 (#3774, #3788,
#3811, #3804, #3815, #3823)
- [core] Update package type to `commonjs`
- [logger] Review factory code part: use `switch/case` instead of
`if/else if` (#3812)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Teeuw <michael@xonaymedia.nl>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Veeck <github@veeck.de>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: jkriegshauser <joshuakr@nvidia.com>
Co-authored-by: illimarkangur <116028111+illimarkangur@users.noreply.github.com>
Co-authored-by: sam detweiler <sdetweil@gmail.com>
Co-authored-by: vppencilsharpener <tim.pray@gmail.com>
Co-authored-by: veeck <michael.veeck@nebenan.de>
Co-authored-by: Paranoid93 <6515818+Paranoid93@users.noreply.github.com>
Co-authored-by: Brian O'Connor <btoconnor@users.noreply.github.com>
Co-authored-by: WallysWellies <59727507+WallysWellies@users.noreply.github.com>
Co-authored-by: Jason Stieber <jrstieber@gmail.com>
Co-authored-by: jargordon <50050429+jargordon@users.noreply.github.com>
Co-authored-by: Daniel <32464403+dkallen78@users.noreply.github.com>
Co-authored-by: Ryan Williams <65094007+ryan-d-williams@users.noreply.github.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Marc Landis <dirk.rettschlag@gmail.com>
Co-authored-by: HeikoGr <20295490+HeikoGr@users.noreply.github.com>
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
Co-authored-by: veeck <gitkraken@veeck.de>
Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com>
Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
Co-authored-by: DevIncomin <56730075+Developer-Incoming@users.noreply.github.com>
Co-authored-by: Nathan <n8nyoung@gmail.com>
Co-authored-by: mixasgr <mixasgr@users.noreply.github.com>
Co-authored-by: Savvas Adamtziloglou <savvas-gr@greeklug.gr>
Co-authored-by: Konstantinos <geraki@gmail.com>
Co-authored-by: OWL4C <124401812+OWL4C@users.noreply.github.com>
Co-authored-by: BugHaver <43462320+bughaver@users.noreply.github.com>
Co-authored-by: BugHaver <43462320+lsaadeh@users.noreply.github.com>
Co-authored-by: Koen Konst <koenspero@gmail.com>
Co-authored-by: Koen Konst <c.h.konst@avisi.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants