Skip to content

update deps and fix style issue in js/class.js #3289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rejas merged 1 commit into from
Dec 13, 2023
Merged

update deps and fix style issue in js/class.js #3289

rejas merged 1 commit into from
Dec 13, 2023

Conversation

@khassel
Copy link
Collaborator

@khassel khassel commented Dec 13, 2023

see title, should be merged because style tests are failing, see #3284 (comment)

@khassel
Copy link
Collaborator Author

khassel commented Dec 13, 2023

the failing calendar test is the next problem, this should me merged anyway because I had this calendar error before so not related to this.

@khassel khassel requested a review from rejas December 13, 2023 19:18
@khassel khassel mentioned this pull request Dec 13, 2023
Merged
@rejas rejas merged commit d5406f4 into MagicMirrorOrg:develop Dec 13, 2023
rejas pushed a commit that referenced this pull request Dec 13, 2023
@khassel
start electron with --disable-gpu flag (#3290)
319a921 
can be overriden with env var ELECTRON_ENABLE_GPU=1.

see #3226 

Tests will fail as long as
#3289 is not merged.
@khassel khassel deleted the update_deps branch December 13, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rejas rejas rejas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khassel @rejas