Skip to content

Conversation

@bnitkin
Copy link
Contributor

@bnitkin bnitkin commented Dec 4, 2023

This change replaces the font-awesome moon icon and percent-lit with an icon showing the current lunar phase.

It uses emoji, which may not be installed on all machines. The fallback text version is backwards (the dark part of the moon is text-color, which is normally black but white in MagicMirror).

@bnitkin
Copy link
Contributor Author

bnitkin commented Dec 4, 2023

Here's the clock with the new icon:

2023-12-04-165622_370x181_scrot

@KristjanESPERANTO
Copy link
Collaborator

I like the idea and the implementation with emojis! 😃 Can you provide a screenshot of what it looked like before for comparison? I can't test it right now, but wasn't there a percentage behind the moon?

@khassel
Copy link
Collaborator

khassel commented Dec 5, 2023

grafik

I'm not sure if all people like the yellow color so maybe a better approach would be to add a new config option or change showMoonTimes from true/false to e.g. none/percent/emoji

@bnitkin
Copy link
Contributor Author

bnitkin commented Dec 6, 2023

I like that idea. I can take a swing at that over the weekend and push some updates!

@bnitkin
Copy link
Contributor Author

bnitkin commented Dec 13, 2023

Just pushed an update - thoughts? Here's a screenshot of the various configs:
2023-12-12-190251_274x612_scrot

The parsing logic is fairly relaxed. A falsy value with turn times off; anything truthy enables times (so people with showMoonTimes=true will keep seeing times). "percent", "phase", and "both" enable the percent-lit and/or phase image.

Top to bottom is

false
"times"
"percent"
"phase"
"both"

@rejas rejas merged commit 55cd035 into MagicMirrorOrg:develop Dec 13, 2023
@rejas
Copy link
Collaborator

rejas commented Dec 13, 2023

Thanks. Can you now prepare a PR for the Documentation repo?

@khassel
Copy link
Collaborator

khassel commented Dec 13, 2023

@rejas I'm getting

> magicmirror@2.26.0-develop test:prettier
> prettier . --check
Checking formatting...
[warn] js/class.js
[warn] Code style issues found in the above file. Run Prettier to fix.

since this is merged on develop

@khassel
Copy link
Collaborator

khassel commented Dec 13, 2023

seems unrelated, maybe new deps

rejas pushed a commit that referenced this pull request Dec 13, 2023
see title, should be merged because style tests are failing, see
#3284 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants