-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Show moon phase in clock module #3284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I like the idea and the implementation with emojis! 😃 Can you provide a screenshot of what it looked like before for comparison? I can't test it right now, but wasn't there a percentage behind the moon? |
|
I like that idea. I can take a swing at that over the weekend and push some updates! |
|
Thanks. Can you now prepare a PR for the Documentation repo? |
|
@rejas I'm getting > magicmirror@2.26.0-develop test:prettier
> prettier . --check
Checking formatting...
[warn] js/class.js
[warn] Code style issues found in the above file. Run Prettier to fix.since this is merged on |
|
seems unrelated, maybe new deps |
see title, should be merged because style tests are failing, see #3284 (comment)



This change replaces the font-awesome moon icon and percent-lit with an icon showing the current lunar phase.
It uses emoji, which may not be installed on all machines. The fallback text version is backwards (the dark part of the moon is text-color, which is normally black but white in MagicMirror).