Skip to content

Conversation

@rejas
Copy link
Collaborator

@rejas rejas commented Oct 27, 2022

Some small cleanups with regards to jest

  • call jest directly (nyc is integrated in jest these days)
  • move jest config into seperate file so we dont clutter up the package.json
  • remove empty test file for newsletter-unit-tests
  • update dependencies that touch jest
  • try out v8 as coverageProvider

@rejas rejas force-pushed the jest branch 2 times, most recently from 15da9ed to 207c2f2 Compare October 27, 2022 20:08
@rejas rejas changed the title Cleanup jest Cleanup jest config Oct 27, 2022
@rejas rejas marked this pull request as ready for review October 27, 2022 21:10
package.json Outdated
"jest": "^29.2.2",
"jsdom": "^20.0.1",
"lodash": "^4.17.21",
"nyc": "^15.1.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is nyc still needed here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, removed it now

@codecov-commenter
Copy link

Codecov Report

Merging #2959 (6ac63f1) into develop (c191ff0) will decrease coverage by 42.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #2959       +/-   ##
============================================
- Coverage    65.21%   23.04%   -42.17%     
============================================
  Files           14       48       +34     
  Lines          733    10008     +9275     
============================================
+ Hits           478     2306     +1828     
- Misses         255     7702     +7447     
Impacted Files Coverage Δ
js/electron.js 0.00% <0.00%> (-70.97%) ⬇️
js/logger.js 46.83% <0.00%> (-5.80%) ⬇️
js/utils.js 100.00% <0.00%> (ø)
js/deprecated.js 100.00% <0.00%> (ø)
modules/default/defaultmodules.js 100.00% <0.00%> (ø)
modules/default/alert/notificationFx.js 0.00% <0.00%> (ø)
modules/default/updatenotification/node_helper.js 74.28% <0.00%> (ø)
modules/default/calendar/calendar.js 33.29% <0.00%> (ø)
modules/default/newsfeed/node_helper.js 77.01% <0.00%> (ø)
modules/default/newsfeed/newsfeedfetcher.js 72.06% <0.00%> (ø)
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@khassel khassel merged commit f79d3f0 into MagicMirrorOrg:develop Oct 28, 2022
@rejas rejas deleted the jest branch October 28, 2022 18:59
@rejas
Copy link
Collaborator Author

rejas commented Oct 28, 2022

FYI: I think the coverage goes down so drastically because now we really check all js files. Prior to this PR the list of files was a lot less:
https://github.com/MichMich/MagicMirror/actions/runs/3282686049/jobs/5406418456

@khassel
Copy link
Collaborator

khassel commented Oct 28, 2022

this test did never produce any logical output so I'm ignoring this (and therefore didn't see the great difference) ...

@rejas
Copy link
Collaborator Author

rejas commented Oct 28, 2022

:-D Lets hope they stay now a little more consistent.

@MichMich MichMich mentioned this pull request Jan 1, 2023
MichMich added a commit that referenced this pull request Jan 1, 2023
## [2.22.0] - 2023-01-01

Thanks to: @angeldeejay, @buxxi, @dariom, @dWoolridge,
@KristjanESPERANTO, @MagMar94, @naveensrinivasan, @retroflex, @SkySails
and @tom.

Special thanks to @khassel, @rejas and @sdetweil for taking over most
(if not all) of the work on this release as project collaborators. This
version would not be there without their effort. Thank you!

### Added

- Added test for remoteFile option in compliments module
- Added hourlyWeather functionality to Weather.gov weather provider
- Removed weatherEndpoint definition from weathergov.js (not used)
- Added css class names "today" and "tomorrow" for default calendar
- Added Collaboration.md
- Added new github action for dependency review (#2862)
- Added a WeatherProvider for Open-Meteo
- Added Yr as a weather provider
- Added config options "ignoreXOriginHeader" and
"ignoreContentSecurityPolicy"

### Removed

- Removed usage of internal fetch function of node until it is more
stable

### Updated

- Cleaned up test directory (#2937) and jest config (#2959)
- Wait for all modules to start before declaring the system ready
(#2487)
- Updated e2e tests (moved `done()` in helper functions) and use es6
syntax in all tests
- Updated da translation
- Rework weather module
- Make sure smhi provider api only gets a maximum of 6 digits
coordinates (#2955)
  - Use fetch instead of XMLHttpRequest in weatherprovider (#2935)
  - Reworked how weatherproviders handle units (#2849)
  - Use unix() method for parsing times, fix suntimes on the way (#2950)
  - Refactor conversion functions into utils class (#2958)
- The `cors`-method in `server.js` now supports sending and recieving
HTTP headers
- Replace `&hellip;` by `…`
- Cleanup compliments module
- Updated dependencies including electron to v22 (#2903)

### Fixed

- Correctly show apparent temperature in SMHI weather provider
- Ensure updatenotification module isn't shown when local is _ahead_ of
remote
- Handle node_helper errors during startup (#2944)
- Possibility to change FontAwesome class in calendar, so icons like
`fab fa-facebook-square` works.
- Fix cors problems with newsfeed articles (as far as possible), allow
disabling cors per feed with option `useCorsProxy: false` (#2840)
- Tests not waiting for the application to start and stop before
starting the next test
- Fix electron tests failing sometimes in github workflow
- Fixed gap in clock module when displayed on the left side with
displayType=digital
- Fixed playwright issue by upgrading to v1.29.1 (#2969)

Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Malte Hallström <46646495+SkySails@users.noreply.github.com>
Co-authored-by: Veeck <github@veeck.de>
Co-authored-by: veeck <michael@veeck.de>
Co-authored-by: dWoolridge <dwoolridge@charter.net>
Co-authored-by: Johan <jojjepersson@yahoo.se>
Co-authored-by: Dario Mratovich <dario_mratovich@hotmail.com>
Co-authored-by: Dario Mratovich <dario.mratovich@outlook.com>
Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com>
Co-authored-by: Naveen <172697+naveensrinivasan@users.noreply.github.com>
Co-authored-by: buxxi <buxxi@omfilm.net>
Co-authored-by: Thomas Hirschberger <47733292+Tom-Hirschberger@users.noreply.github.com>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: Andrés Vanegas Jiménez <142350+angeldeejay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants