Skip to content

Support for workflow summary#89

Merged
thsaravana merged 5 commits into
Madrapps:workflow_summaryfrom
yijhenlin:summary_mode
Sep 18, 2024
Merged

Support for workflow summary#89
thsaravana merged 5 commits into
Madrapps:workflow_summaryfrom
yijhenlin:summary_mode

Conversation

@yijhenlin

Copy link
Copy Markdown
Contributor

Add an option for workflow summary.
Fix #88

@thsaravana

thsaravana commented Sep 18, 2024

Copy link
Copy Markdown
Member

Sorry about the late reply. We just picking this for milestone v1.7.2. The dist is auto-generated files. Could you make the changes to the .ts files with this change?

@thsaravana thsaravana changed the base branch from main to workflow_summary September 18, 2024 17:22
@thsaravana

Copy link
Copy Markdown
Member

We are taking a different approach to this:

  1. We will have an option to either do a PR Comment or Workflow Summary, as well as "both" at the same time. We will develop this further on adding more detailed report in the workflow summary later.
  2. The token can't be optional, since we are using this to calculate the "changed files". So we are going to keep it required

We would still like to give you credit for raising the issue and raising the initial PR. Thanks!

@thsaravana thsaravana merged commit 4943c7b into Madrapps:workflow_summary Sep 18, 2024
thsaravana added a commit that referenced this pull request Sep 18, 2024
* Write to workflow summary

* Write to workflow summary - only body

* Add choice type

* Print comment-type

* Run build

* Adding commentType validation

* Code cleanup

* Adapt tests

* Adding more tests

* Adding tests for validation

* Support for workflow summary (#89)

* Add summary_mode

* Token is not necessary for workflow summary

* Add summary_mode in action.ts

* Update description for comment-type field

---------

Co-authored-by: thsaravana <th.saravana@gmail.com>

---------

Co-authored-by: YiJhen Lin <44198696+yijhenlin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for workflow summary

2 participants