Merged
Conversation
added 5 commits
September 29, 2015 14:05
RI from upstream/dev into origin/release
RI from release into dev1
RI from dev1 into dev1-anudeeb
… versions with Venus addition
There was a problem hiding this comment.
Instead of doing string comparision for enum, better use tryParseEnum method.
public static bool TryParse(string value, bool ignoreCase, out TEnum result) where TEnum : struct;
Actually I see Enum.Parse is being used at many places in powershell , this should bot be used . we shpuld use TryParse method to keep is compatibile with any new enum value coming in.
dragonfly91
pushed a commit
that referenced
this pull request
Oct 1, 2015
Fix for Bug 4751044. Signed off by SureshT and Vsarg.
There was a problem hiding this comment.
Better use TryParse here also instead of Enum.Parse
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Bug 4751044 : Get-AzureRMBackupContainer will fail in older PSH versions with Venus addition