Conversation
Contributor
Author
|
因为在这个界面的物品上还会显示价值,所以效果很差。 {
"name": "DeliveryJobsSelectItemToFill",
"algorithm": "NeuralNetworkDetect",
"hit": false,
"box": [0, 0, 0, 0],
"detail": {
"all": [
{
"box": [243, 463, 82, 76],
"cls_index": 137,
"label": "蓝铁块",
"score": 0.933271
},
{
"box": [242, 171, 86, 89],
"cls_index": 90,
"label": "砂叶粉末",
"score": 0.475505
},
{
"box": [332, 313, 89, 87],
"cls_index": 170,
"label": "铁制零件",
"score": 0.35104
}
],
"best": null,
"filtered": []
}
} |
5755bc4 to
b742703
Compare
Contributor
|
ok了,我这边运行正常,你看看 adb 要不要测 |
Contributor
Author
要测试,明天我测试后再合并吧。 |
8a26dac to
1b7ec29
Compare
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些高层面的反馈:
- 新的
PackCargo.json流水线同时出现在resource_fast和resource_adb中;请考虑将任何共享的配置抽取出来,或者清楚地记录有意为之的差异,以降低这两个配置随时间逐渐偏离的风险。
给 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- The new `PackCargo.json` pipeline appears in both `resource_fast` and `resource_adb`; consider factoring out any shared configuration or clearly documenting intentional differences to reduce the risk of the two drifting over time.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- The new
PackCargo.jsonpipeline appears in bothresource_fastandresource_adb; consider factoring out any shared configuration or clearly documenting intentional differences to reduce the risk of the two drifting over time.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `PackCargo.json` pipeline appears in both `resource_fast` and `resource_adb`; consider factoring out any shared configuration or clearly documenting intentional differences to reduce the risk of the two drifting over time.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
本 PR 为 DeliveryJobs(自动转交送货)任务新增了选择要填充货物类型的功能,解决了 #546 中描述的默认"塞满"操作可能装入不期望货物的问题。通过 anchor 机制根据进入的仓储区域(四号谷地/武陵)动态解析对应的货物选择节点。
Changes:
- 新增
PackCargoSelectItemswitch 选项,允许用户启用/禁用指定货物填充功能,并为四号谷地和武陵分别提供下拉选择框选择要填充的货物种类 - 新增 Pipeline 节点
DeliveryJobsSelectItemToFillValleyIV、DeliveryJobsSelectItemToFillWuling、DeliveryJobsFillCorrespondingGoods,通过 TemplateMatch 识别和点击来实现选择指定货物并填满 - 在 DepotNode.json 中为各仓储入口节点添加
anchor属性,使流程可根据当前区域动态解析到正确的货物选择节点
Reviewed changes
Copilot reviewed 12 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| assets/tasks/DeliveryJobs.json | 新增 PackCargoSelectItem、WhatToFillValleyIV、WhatToFillWuling 选项定义 |
| assets/resource_fast/pipeline/DeliveryJobs/PackCargo.json | 新增三个 Pipeline 节点用于选择和填充指定货物 |
| assets/resource_fast/pipeline/DeliveryJobs/DepotNode.json | 为各仓储入口节点添加 anchor 属性以支持区域感知的动态分发 |
| assets/resource_adb/pipeline/DeliveryJobs/PackCargo.json | 新增 ADB 控制器下 DeliveryJobsFillCorrespondingGoods 的 target_offset 覆盖 |
| assets/resource_fast/image/DeliveryJobs/*.png | 新增货物选择和填充所需的模板图片(resource_fast) |
| assets/resource_adb/image/DeliveryJobs/*.png | 新增货物选择和填充所需的模板图片(resource_adb) |
| assets/resource_fast/image/DeliveryJobs/README.md | 说明此目录图片含物品价值信息,不可复用 |
| assets/misc/locales/*.json | 为所有支持语言新增货物选择相关的本地化字符串 |
| tests/DeliveryJobs/test_pack_cargo.json | 更新 Win32 测试用例,覆盖新增节点的识别验证 |
| tests/DeliveryJobs/test_pack_cargo_adb.json | 更新 ADB 测试用例,覆盖新增节点的识别验证 |
f0ec085 to
81426f9
Compare
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
close #546 ## Summary by Sourcery 为 DeliveryJobs 添加可配置的货物选择功能,并相应更新相关流水线、任务、资源和测试。 新功能: - 允许 DeliveryJobs 指定并选择在自动配送工作流中要打包的货物条目。 增强: - 更新 DeliveryJobs 的流水线和任务配置,以在标准版和 ADB 变体中支持新的货物选择行为。 - 刷新 DeliveryJobs 的本地化条目,以涵盖新的货物选择用户体验(UX)。 文档: - 在 DeliveryJobs 的图片资源目录下新增 README,记录物品选择界面图片的使用限制。 测试: - 扩展 DeliveryJobs 的打包测试(包括 ADB 专用测试),以覆盖新的货物选择逻辑。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Add configurable cargo selection to DeliveryJobs, updating related pipelines, tasks, assets, and tests accordingly. New Features: - Allow DeliveryJobs to specify and select which cargo items are packed during automatic delivery workflows. Enhancements: - Update DeliveryJobs pipeline and task configurations to support the new cargo selection behavior across standard and ADB variants. - Refresh localization entries for DeliveryJobs to cover the new cargo selection UX. Documentation: - Add a README under DeliveryJobs image resources documenting usage constraints for item selection UI images. Tests: - Extend DeliveryJobs packing tests, including ADB-specific tests, to cover the new cargo selection logic. </details> <details> <summary>Original summary in English</summary> ## Summary by Sourcery 为 DeliveryJobs 添加可配置的货物选择功能,并相应更新相关流水线、任务、资源和测试。 新功能: - 允许 DeliveryJobs 指定并选择在自动配送工作流中要打包的货物条目。 增强: - 更新 DeliveryJobs 的流水线和任务配置,以在标准版和 ADB 变体中支持新的货物选择行为。 - 刷新 DeliveryJobs 的本地化条目,以涵盖新的货物选择用户体验(UX)。 文档: - 在 DeliveryJobs 的图片资源目录下新增 README,记录物品选择界面图片的使用限制。 测试: - 扩展 DeliveryJobs 的打包测试(包括 ADB 专用测试),以覆盖新的货物选择逻辑。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Add configurable cargo selection to DeliveryJobs, updating related pipelines, tasks, assets, and tests accordingly. New Features: - Allow DeliveryJobs to specify and select which cargo items are packed during automatic delivery workflows. Enhancements: - Update DeliveryJobs pipeline and task configurations to support the new cargo selection behavior across standard and ADB variants. - Refresh localization entries for DeliveryJobs to cover the new cargo selection UX. Documentation: - Add a README under DeliveryJobs image resources documenting usage constraints for item selection UI images. Tests: - Extend DeliveryJobs packing tests, including ADB-specific tests, to cover the new cargo selection logic. </details> </details> --------- Co-authored-by: 晓丶梦丶仁 <74444214+Daydreamer114@users.noreply.github.com>
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
close #546 ## Summary by Sourcery 为 DeliveryJobs 添加可配置的货物选择功能,并相应更新相关流水线、任务、资源和测试。 新功能: - 允许 DeliveryJobs 指定并选择在自动配送工作流中要打包的货物条目。 增强: - 更新 DeliveryJobs 的流水线和任务配置,以在标准版和 ADB 变体中支持新的货物选择行为。 - 刷新 DeliveryJobs 的本地化条目,以涵盖新的货物选择用户体验(UX)。 文档: - 在 DeliveryJobs 的图片资源目录下新增 README,记录物品选择界面图片的使用限制。 测试: - 扩展 DeliveryJobs 的打包测试(包括 ADB 专用测试),以覆盖新的货物选择逻辑。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Add configurable cargo selection to DeliveryJobs, updating related pipelines, tasks, assets, and tests accordingly. New Features: - Allow DeliveryJobs to specify and select which cargo items are packed during automatic delivery workflows. Enhancements: - Update DeliveryJobs pipeline and task configurations to support the new cargo selection behavior across standard and ADB variants. - Refresh localization entries for DeliveryJobs to cover the new cargo selection UX. Documentation: - Add a README under DeliveryJobs image resources documenting usage constraints for item selection UI images. Tests: - Extend DeliveryJobs packing tests, including ADB-specific tests, to cover the new cargo selection logic. </details> <details> <summary>Original summary in English</summary> ## Summary by Sourcery 为 DeliveryJobs 添加可配置的货物选择功能,并相应更新相关流水线、任务、资源和测试。 新功能: - 允许 DeliveryJobs 指定并选择在自动配送工作流中要打包的货物条目。 增强: - 更新 DeliveryJobs 的流水线和任务配置,以在标准版和 ADB 变体中支持新的货物选择行为。 - 刷新 DeliveryJobs 的本地化条目,以涵盖新的货物选择用户体验(UX)。 文档: - 在 DeliveryJobs 的图片资源目录下新增 README,记录物品选择界面图片的使用限制。 测试: - 扩展 DeliveryJobs 的打包测试(包括 ADB 专用测试),以覆盖新的货物选择逻辑。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Add configurable cargo selection to DeliveryJobs, updating related pipelines, tasks, assets, and tests accordingly. New Features: - Allow DeliveryJobs to specify and select which cargo items are packed during automatic delivery workflows. Enhancements: - Update DeliveryJobs pipeline and task configurations to support the new cargo selection behavior across standard and ADB variants. - Refresh localization entries for DeliveryJobs to cover the new cargo selection UX. Documentation: - Add a README under DeliveryJobs image resources documenting usage constraints for item selection UI images. Tests: - Extend DeliveryJobs packing tests, including ADB-specific tests, to cover the new cargo selection logic. </details> </details> --------- Co-authored-by: 晓丶梦丶仁 <74444214+Daydreamer114@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #546
Summary by Sourcery
为 DeliveryJobs 添加可配置的货物选择功能,并相应更新相关流水线、任务、资源和测试。
新功能:
增强:
文档:
测试:
Original summary in English
Summary by Sourcery
Add configurable cargo selection to DeliveryJobs, updating related pipelines, tasks, assets, and tests accordingly.
New Features:
Enhancements:
Documentation:
Tests:
Original summary in English
Summary by Sourcery
为 DeliveryJobs 添加可配置的货物选择功能,并相应更新相关流水线、任务、资源和测试。
新功能:
增强:
文档:
测试:
Original summary in English
Summary by Sourcery
Add configurable cargo selection to DeliveryJobs, updating related pipelines, tasks, assets, and tests accordingly.
New Features:
Enhancements:
Documentation:
Tests: