Conversation
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体性的反馈：
- 由于通用 Button pipeline 从
assets/resource/pipeline/Common/Button.json移动到了assets/resource_fast/pipeline/Common/Button.json，请再次确认所有现有的引用和 include 都已经指向新的 fast 路径，以避免运行时解析问题。 - 现在在
resource_adb和resource_fast下都存在 Button 定义；建议将共享配置去重，或者清晰地拆分出平台特定字段，以避免这两套按钮行为在未来出现不一致的演化。 - 新增的 80ms 全屏
post_wait_freezes可能会影响用户感知到的响应速度；建议确认这个延迟只在确有必要的场景下才会生效，并且不会被那些不需要全屏停顿的流程继承。
面向 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- 由于通用 Button pipeline 从 `assets/resource/pipeline/Common/Button.json` 移动到了 `assets/resource_fast/pipeline/Common/Button.json`，请再次确认所有现有的引用和 include 都已经指向新的 fast 路径，以避免运行时解析问题。
- 现在在 `resource_adb` 和 `resource_fast` 下都存在 Button 定义；建议将共享配置去重，或者清晰地拆分出平台特定字段，以避免这两套按钮行为在未来出现不一致的演化。
- 新增的 80ms 全屏 `post_wait_freezes` 可能会影响用户感知到的响应速度；建议确认这个延迟只在确有必要的场景下才会生效，并且不会被那些不需要全屏停顿的流程继承。帮我更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈来改进后续的评审。
Original comment in English
Hey - I've left some high level feedback:
- Since the generic Button pipeline was moved from
assets/resource/pipeline/Common/Button.jsontoassets/resource_fast/pipeline/Common/Button.json, double-check that all existing references and includes now point to the new fast path to avoid runtime resolution issues. - There are now Button definitions under both
resource_adbandresource_fast; consider deduplicating shared configuration or clearly separating platform-specific fields to avoid divergence between the two button behaviors over time. - The newly added 80ms full-screen
post_wait_freezesmight affect perceived responsiveness; it would be good to confirm this delay is only applied where strictly necessary and not inherited by flows that don’t require a full-screen pause.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the generic Button pipeline was moved from `assets/resource/pipeline/Common/Button.json` to `assets/resource_fast/pipeline/Common/Button.json`, double-check that all existing references and includes now point to the new fast path to avoid runtime resolution issues.
- There are now Button definitions under both `resource_adb` and `resource_fast`; consider deduplicating shared configuration or clearly separating platform-specific fields to avoid divergence between the two button behaviors over time.
- The newly added 80ms full-screen `post_wait_freezes` might affect perceived responsiveness; it would be good to confirm this delay is only applied where strictly necessary and not inherited by flows that don’t require a full-screen pause.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates all common button definitions from the base resource layer to the resource_fast layer and updates the full-screen freeze detection timeout from 1ms to 80ms across all button actions.
Changes:
- Moves common button definitions from
assets/resource/pipeline/Common/Button.jsontoassets/resource_fast/pipeline/Common/Button.json - Adds new
assets/resource_fast/pipeline/Common/Status.jsonfile containingWaitLoadingColorandESCMenustatus detection nodes - Updates all
post_wait_freezes.timevalues from 1ms to 80ms for full-screen freeze detection across multiple pipeline files - Replaces
BackButtonnode references with the more specificCloseButtonType1node - Migrates button template images to
resource_fast/image/Common/Button/directory for both PC and ADB resources
Reviewed changes
Copilot reviewed 9 out of 41 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| assets/resource_fast/pipeline/Common/Button.json | Adds comprehensive button definitions with 80ms post_wait_freezes, including all button types previously in base resource plus new button background detection nodes |
| assets/resource_fast/pipeline/Common/Status.json | New file defining WaitLoadingColor and ESCMenu status detection nodes |
| assets/resource_fast/pipeline/Common/ChangeRegion.json | Updates post_wait_freezes from 1ms to 80ms and replaces BackButton with CloseButtonType1 |
| assets/resource_fast/pipeline/DeliveryJobs/*.json | Updates post_wait_freezes from 1ms to 80ms and replaces BackButton with CloseButtonType1 |
| assets/resource_fast/image/Common/Button/*.png | Adds all button template images to resource_fast layer |
| assets/resource/pipeline/Common/Button.json | Deleted - fully migrated to resource_fast |
| assets/resource/pipeline/DailyRewards/Emails.json | Updates BackButton reference to CloseButtonType1 |
| assets/resource/pipeline/CreditShopping/Shopping.json | Updates BackButton reference to CloseButtonType1 |
| assets/resource_adb/pipeline/Common/Button.json | Updates post_wait_freezes from 1ms to 80ms for ADB-specific button actions |
| assets/resource_adb/image/Common/Button/*.png | Adds ADB-specific button template images |
Contributor
|
奈斯，鲁棒性++ |
Closed
HYY1116
pushed a commit
to HYY1116/MaaEnd
that referenced
this pull request
Feb 25, 2026
同时添加了 80 毫秒的全屏 post_wait_freezes。 ## Summary by Sourcery 将共享按钮流水线定义移动到快速流水线资源中，并相应调整与信用购物、每日奖励和配送任务相关的流水线。 新功能： - 为常用按钮及相关配送任务交互引入快速流水线变体。 优化改进： - 从默认流水线集合中移除旧版的通用按钮流水线资源，改用面向快速流水线的专用资源。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Move shared button pipeline definitions into the fast pipeline resources and adjust related pipelines for credit shopping, daily rewards, and delivery jobs. New Features: - Introduce fast pipeline variants for common buttons and related delivery job interactions. Enhancements: - Remove legacy common button pipeline resource from the default pipeline set in favor of fast-specific resources. </details>
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
同时添加了 80 毫秒的全屏 post_wait_freezes。 ## Summary by Sourcery 将共享按钮流水线定义移动到快速流水线资源中，并相应调整与信用购物、每日奖励和配送任务相关的流水线。 新功能： - 为常用按钮及相关配送任务交互引入快速流水线变体。 优化改进： - 从默认流水线集合中移除旧版的通用按钮流水线资源，改用面向快速流水线的专用资源。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Move shared button pipeline definitions into the fast pipeline resources and adjust related pipelines for credit shopping, daily rewards, and delivery jobs. New Features: - Introduce fast pipeline variants for common buttons and related delivery job interactions. Enhancements: - Remove legacy common button pipeline resource from the default pipeline set in favor of fast-specific resources. </details>
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
同时添加了 80 毫秒的全屏 post_wait_freezes。 ## Summary by Sourcery 将共享按钮流水线定义移动到快速流水线资源中，并相应调整与信用购物、每日奖励和配送任务相关的流水线。 新功能： - 为常用按钮及相关配送任务交互引入快速流水线变体。 优化改进： - 从默认流水线集合中移除旧版的通用按钮流水线资源，改用面向快速流水线的专用资源。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Move shared button pipeline definitions into the fast pipeline resources and adjust related pipelines for credit shopping, daily rewards, and delivery jobs. New Features: - Introduce fast pipeline variants for common buttons and related delivery job interactions. Enhancements: - Remove legacy common button pipeline resource from the default pipeline set in favor of fast-specific resources. </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
同时添加了 80 毫秒的全屏 post_wait_freezes。
Summary by Sourcery
将共享按钮流水线定义移动到快速流水线资源中，并相应调整与信用购物、每日奖励和配送任务相关的流水线。
新功能：
优化改进：
Original summary in English
Summary by Sourcery
Move shared button pipeline definitions into the fast pipeline resources and adjust related pipelines for credit shopping, daily rewards, and delivery jobs.
New Features:
Enhancements: