Skip to content

refactor: 提取出一些通用界面判断节点#655

Merged
he0119 merged 10 commits intomainfrom
refactor/common-region
Feb 21, 2026
Merged

refactor: 提取出一些通用界面判断节点#655
he0119 merged 10 commits intomainfrom
refactor/common-region

Conversation

@he0119
Copy link
Contributor

@he0119 he0119 commented Feb 21, 2026

Summary by Sourcery

将共享的 UI 决策节点提取为通用的流水线资源,并更新各个功能相关的流水线以使用这些共享资源。

增强内容:

  • 将区域变更逻辑从 Resell 流水线中移出,迁移到共享的 Common ChangeRegion 和 Region 流水线资源中。
  • 更新 DeliveryJobs 流水线(DepotNode、PackCargo、TransferJob),使其引用共享的通用区域相关节点,而不是重复实现相同逻辑。
  • 引入共享的 Text 流水线资源,用于可复用的文本相关 UI 节点。
Original summary in English

Summary by Sourcery

Extract shared UI decision nodes into common pipeline resources and update feature-specific pipelines to use them.

Enhancements:

  • Move region change logic from the Resell pipeline into shared Common ChangeRegion and Region pipeline resources.
  • Update DeliveryJobs pipelines (DepotNode, PackCargo, TransferJob) to reference shared common region-related nodes instead of duplicating logic.
  • Introduce a shared Text pipeline resource for reusable text-related UI nodes.

Copilot AI review requested due to automatic review settings February 21, 2026 01:38
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我已经审查了你的更改,一切看起来都很棒!


Sourcery 对开源项目是免费的——如果你觉得我们的代码审查有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的代码审查。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

assets/resource/pipeline/Resell/ChangeRegion.json:110

  • The node name replacement appears incorrect. The comment "切换到武陵继续售卖" (Switch to Wuling to continue selling) and the next action "[JumpBack]GoToWuling" indicate this node should check if we're currently in Valley IV (before switching to Wuling), not if we're already in Wuling. The original "CheckValleyIV" should have been replaced with "InValleyIVRegionalDevelopment", not "InWulingRegionalDevelopment".
    "ChangeNextRegionToWuling": {
        "doc": "切换到武陵继续售卖",
        "recognition": "Or",
        "any_of": [
            "InWulingRegionalDevelopment"
        ],
        "action": "DoNothing",
        "next": [
            "ChangeNextRegionDone",
            "[JumpBack]GoToWuling"
        ]

@he0119 he0119 merged commit fc7932d into main Feb 21, 2026
17 checks passed
@he0119 he0119 deleted the refactor/common-region branch February 21, 2026 02:29
HYY1116 pushed a commit to HYY1116/MaaEnd that referenced this pull request Feb 25, 2026
## Summary by Sourcery

将共享的 UI 决策节点提取为通用的流水线资源,并更新各个功能相关的流水线以使用这些共享资源。

增强内容:
- 将区域变更逻辑从 Resell 流水线中移出,迁移到共享的 Common ChangeRegion 和 Region 流水线资源中。
- 更新 DeliveryJobs
流水线(DepotNode、PackCargo、TransferJob),使其引用共享的通用区域相关节点,而不是重复实现相同逻辑。
- 引入共享的 Text 流水线资源,用于可复用的文本相关 UI 节点。

<details>
<summary>Original summary in English</summary>

## Summary by Sourcery

Extract shared UI decision nodes into common pipeline resources and
update feature-specific pipelines to use them.

Enhancements:
- Move region change logic from the Resell pipeline into shared Common
ChangeRegion and Region pipeline resources.
- Update DeliveryJobs pipelines (DepotNode, PackCargo, TransferJob) to
reference shared common region-related nodes instead of duplicating
logic.
- Introduce a shared Text pipeline resource for reusable text-related UI
nodes.

</details>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MistEO pushed a commit that referenced this pull request Mar 9, 2026
## Summary by Sourcery

将共享的 UI 决策节点提取为通用的流水线资源,并更新各个功能相关的流水线以使用这些共享资源。

增强内容:
- 将区域变更逻辑从 Resell 流水线中移出,迁移到共享的 Common ChangeRegion 和 Region 流水线资源中。
- 更新 DeliveryJobs
流水线(DepotNode、PackCargo、TransferJob),使其引用共享的通用区域相关节点,而不是重复实现相同逻辑。
- 引入共享的 Text 流水线资源,用于可复用的文本相关 UI 节点。

<details>
<summary>Original summary in English</summary>

## Summary by Sourcery

Extract shared UI decision nodes into common pipeline resources and
update feature-specific pipelines to use them.

Enhancements:
- Move region change logic from the Resell pipeline into shared Common
ChangeRegion and Region pipeline resources.
- Update DeliveryJobs pipelines (DepotNode, PackCargo, TransferJob) to
reference shared common region-related nodes instead of duplicating
logic.
- Introduce a shared Text pipeline resource for reusable text-related UI
nodes.

</details>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
MistEO pushed a commit that referenced this pull request Mar 9, 2026
## Summary by Sourcery

将共享的 UI 决策节点提取为通用的流水线资源,并更新各个功能相关的流水线以使用这些共享资源。

增强内容:
- 将区域变更逻辑从 Resell 流水线中移出,迁移到共享的 Common ChangeRegion 和 Region 流水线资源中。
- 更新 DeliveryJobs
流水线(DepotNode、PackCargo、TransferJob),使其引用共享的通用区域相关节点,而不是重复实现相同逻辑。
- 引入共享的 Text 流水线资源,用于可复用的文本相关 UI 节点。

<details>
<summary>Original summary in English</summary>

## Summary by Sourcery

Extract shared UI decision nodes into common pipeline resources and
update feature-specific pipelines to use them.

Enhancements:
- Move region change logic from the Resell pipeline into shared Common
ChangeRegion and Region pipeline resources.
- Update DeliveryJobs pipelines (DepotNode, PackCargo, TransferJob) to
reference shared common region-related nodes instead of duplicating
logic.
- Introduce a shared Text pipeline resource for reusable text-related UI
nodes.

</details>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants