fix(baker): 🐛 调整 baker 中事务通讯联系人检测方式以处理无红点时无法检测问题#1121
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体反馈：
- 由于现在的检测依赖于特定的颜色值，建议将这些颜色集中管理：要么定义为具名常量，要么在 BAKER.json 中放在一个清晰分离的配置块中，这样未来新增或修改颜色时更易维护、也不容易出错。
- 如果颜色匹配逻辑涉及容差阈值（例如为了适应抗锯齿或轻微的视觉差异），建议在流水线定义中将这些阈值配置化，而不是在代码中硬编码，这样当 UI 渲染发生变化时调整会更方便。
面向 AI Agent 的提示
Please address the comments from this code review:
## Overall Comments
- Since the detection now relies on specific color values, consider centralizing these colors as named constants or a clearly separated configuration block in BAKER.json so that future color additions or changes are easier to manage and less error-prone.
- If the color-matching logic involves tolerance thresholds (e.g., for anti-aliasing or minor visual variations), make those thresholds configurable in the pipeline definition rather than hardcoding them to simplify adjustments when UI rendering changes.帮我变得更有用！请对每条评论点 👍 或 👎，我会根据你的反馈来改进后续的审查。
Original comment in English
Hey - I've left some high level feedback:
- Since the detection now relies on specific color values, consider centralizing these colors as named constants or a clearly separated configuration block in BAKER.json so that future color additions or changes are easier to manage and less error-prone.
- If the color-matching logic involves tolerance thresholds (e.g., for anti-aliasing or minor visual variations), make those thresholds configurable in the pipeline definition rather than hardcoding them to simplify adjustments when UI rendering changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the detection now relies on specific color values, consider centralizing these colors as named constants or a clearly separated configuration block in BAKER.json so that future color additions or changes are easier to manage and less error-prone.
- If the color-matching logic involves tolerance thresholds (e.g., for anti-aliasing or minor visual variations), make those thresholds configurable in the pipeline definition rather than hardcoding them to simplify adjustments when UI rendering changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Closed
MistEO
reviewed
Mar 8, 2026
| "desc": "事务通讯的小红点", | ||
| "recognition": "TemplateMatch", | ||
| "desc": "事务通讯的小竖条, 从匹配红点变成匹配小竖条", | ||
| "recognition": "ColorMatch", |
Contributor
There was a problem hiding this comment.
这玩意的问题不是识别，是会死循环啊
红点 点一下就没了，绿条一直有，就会一直点这个绿条
举个例子画面上有三个 “未读”，这样改完会变成，点第一个 未读，然后把里面的对话正常完成，然后又继续点第一个（刚刚已经完成对话了），然后循环点第一个
Member
Author
There was a problem hiding this comment.
这玩意的问题不是识别，是会死循环啊
红点 点一下就没了，绿条一直有，就会一直点这个绿条
举个例子画面上有三个 “未读”，这样改完会变成，点第一个 未读，然后把里面的对话正常完成，然后又继续点第一个（刚刚已经完成对话了），然后循环点第一个
我尝试了下颜色匹配下，未点击完毕的绿条和点击完毕的绿条颜色是有所差异的（在代码中我注释的颜色就是未点击状态下的颜色）
在自测debug的时候亮色绿条的匹配是匹配不上暗色的绿条
Member
Author
|
玛丽老大辛苦了🥺 |
Contributor
|
对了，因为使用rgb值作识别，那在不同显卡驱动的干扰下表现如何（ |
Member
Author
呀 确实得看看，我只有我这边电脑的测试数据🥲 |
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
因为没有可供测试的样本，所以使用颜色匹配的方案。
事务通讯中小竖条的颜色会根据任务有不同的颜色，后续要是有新颜色的任务需要跟进适配
Summary by Sourcery
调整 BAKER 流水线配置，以在交易沟通联系人检测中处理没有通知指示器的情况。
Bug Fixes:
Enhancements:
Original summary in English
Summary by Sourcery
Adjust BAKER pipeline configuration for transaction communication contact detection to handle cases without notification indicators.
Bug Fixes:
Enhancements: