fix(Common): 暂时注释掉 CloseRewardsButton 的图标识别逻辑#1055
Merged
Conversation
Contributor
There was a problem hiding this comment.
嗨，我已经审阅了你的修改，看起来非常棒！
帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+1023
to
1025
| // FIXME: 一件售卖产品里的图标不一样，暂时注释了 | ||
| // "DectedCloseRewardsImage", | ||
| "__CloseRewardsButton" |
There was a problem hiding this comment.
这里把 DectedCloseRewardsImage 注释掉后，CloseRewardsButton 实际只剩一个子识别（__CloseRewardsButton），并且 DectedCloseRewardsImage 节点在当前代码中已无任何引用。建议把 all_of 顺序调整为先 __CloseRewardsButton、后（可选）DectedCloseRewardsImage，这样即使未来恢复图标检测也不需要依赖/记得 box_index: 1，避免误点到上方图标区域；同时也可以考虑直接改为使用 __CloseRewardsButton（或补充更多图标模板）而不是保留一个单元素 And。
Suggested change
| // FIXME: 一件售卖产品里的图标不一样，暂时注释了 | |
| // "DectedCloseRewardsImage", | |
| "__CloseRewardsButton" | |
| "__CloseRewardsButton" | |
| // FIXME: 一件售卖产品里的图标不一样，暂时注释了 | |
| // "DectedCloseRewardsImage" |
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
不清楚还有哪些界面的图标不同，所以暂时注释。
Summary by Sourcery
改进：
Original summary in English
Summary by Sourcery
Enhancements: