docs: 添加subtask的中英文文档并修改markdownlint以修复map-tracker文档中的警告#1053
Merged
MistEO merged 4 commits intoMaaEnd:mainfrom Mar 6, 2026
Merged
docs: 添加subtask的中英文文档并修改markdownlint以修复map-tracker文档中的警告#1053MistEO merged 4 commits intoMaaEnd:mainfrom
MistEO merged 4 commits intoMaaEnd:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Hey - 我发现了 1 个问题,并留下了一些整体层面的反馈:
- 建议将章节标题
## subtask Action/## subtask 动作改名,使其大小写与类型名(SubTask)保持一致,从而与其余术语更一致。 - 建议明确说明当同时设置
continue: true和strict: true时的组合行为(即:所有子任务都会执行,但如果任一子任务失败,整个动作仍然会失败),这样用户就不需要靠自己推断。
提供给 AI Agent 的提示词
Please address the comments from this code review:
## Overall Comments
- Consider renaming the section headers from `## subtask Action` / `## subtask 动作` to use the same casing as the type (`SubTask`) for consistency with the rest of the terminology.
- It might help to explicitly describe the combined behavior when `continue: true` and `strict: true` are both set (i.e., all subtasks run but the overall action still fails if any subtask fails) so users don’t have to infer it.
## Individual Comments
### Comment 1
<location path="docs/zh_cn/developers/custom-action.md" line_range="22" />
<code_context>
+
+## subtask 动作
+
+`SubTask` 是一个通过 `Custom` 调用的子任务执行动作,实现位于 `agent/go-service/subtask`
+按顺序执行 `custom_action_param` 中 `sub` 字段指定的任务名。
+
</code_context>
<issue_to_address>
**nitpick (typo):** 建议在这个句子末尾加一个句号,以保证标点正确。
这段描述在中文里是一个完整句子,因此应以“。”结尾,以符合标准标点用法,并与英文版本的句号对应。
Suggested implementation:
```
- 按顺序执行多个任务如 `SubTask` 动作。
```
```
- 按顺序执行多个任务如 `SubTask` 动作。
```
</issue_to_address>帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've found 1 issue, and left some high level feedback:
- Consider renaming the section headers from
## subtask Action/## subtask 动作to use the same casing as the type (SubTask) for consistency with the rest of the terminology. - It might help to explicitly describe the combined behavior when
continue: trueandstrict: trueare both set (i.e., all subtasks run but the overall action still fails if any subtask fails) so users don’t have to infer it.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider renaming the section headers from `## subtask Action` / `## subtask 动作` to use the same casing as the type (`SubTask`) for consistency with the rest of the terminology.
- It might help to explicitly describe the combined behavior when `continue: true` and `strict: true` are both set (i.e., all subtasks run but the overall action still fails if any subtask fails) so users don’t have to infer it.
## Individual Comments
### Comment 1
<location path="docs/zh_cn/developers/custom-action.md" line_range="22" />
<code_context>
+
+## subtask 动作
+
+`SubTask` 是一个通过 `Custom` 调用的子任务执行动作,实现位于 `agent/go-service/subtask`
+按顺序执行 `custom_action_param` 中 `sub` 字段指定的任务名。
+
</code_context>
<issue_to_address>
**nitpick (typo):** Consider adding a full stop at the end of this sentence for proper punctuation.
This description is a complete sentence in Chinese, so it should end with a “。” to match standard punctuation and the English version’s period.
Suggested implementation:
```
- 按顺序执行多个任务如 `SubTask` 动作。
```
```
- 按顺序执行多个任务如 `SubTask` 动作。
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Hey - 我在这里给了一些总体性的反馈:
- 在英文和中文两个部分中,建议显式说明当同时使用
continue和strict时的行为(例如continue: true搭配strict: true与strict: false的区别),这样可以让用户更清楚地理解在这些组合下是如何判定整体成功/失败的。
给 AI Agent 的提示词
Please address the comments from this code review:
## Overall Comments
- In both the English and Chinese sections, it might help to explicitly describe the behavior when `continue` and `strict` are used together (e.g., `continue: true` and `strict: true` vs `strict: false`) so users clearly understand how overall success/failure is determined in those combinations.帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进后续的代码审查。
Original comment in English
Hey - I've left some high level feedback:
- In both the English and Chinese sections, it might help to explicitly describe the behavior when
continueandstrictare used together (e.g.,continue: trueandstrict: truevsstrict: false) so users clearly understand how overall success/failure is determined in those combinations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In both the English and Chinese sections, it might help to explicitly describe the behavior when `continue` and `strict` are used together (e.g., `continue: true` and `strict: true` vs `strict: false`) so users clearly understand how overall success/failure is determined in those combinations.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
为 SubTask 自定义动作编写文档,并调整 markdownlint 配置以解决现有的文档警告。
新功能:
构建:
文档:
Original summary in English
Summary by Sourcery
Document the SubTask custom action and adjust markdownlint configuration to address existing documentation warnings.
New Features:
Build:
Documentation:
Original summary in English
Summary by Sourcery
为 SubTask 自定义动作编写文档,并调整 markdownlint 配置以解决现有的文档警告。
新功能:
构建:
文档:
Original summary in English
Summary by Sourcery
Document the SubTask custom action and adjust markdownlint configuration to address existing documentation warnings.
New Features:
Build:
Documentation: