feat(EnvironmentMonitoring): 支持不同任务使用不同的视角调整方案#1043
Merged
Conversation
并且不再共用 max_hit
Contributor
There was a problem hiding this comment.
你好——我已经审查了你的改动，看起来很棒！
帮我变得更有用！请在每条评论上点选 👍 或 👎，我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
本 PR 针对 EnvironmentMonitoring（环境监测） 的拍照流程做了结构调整，使不同任务可以配置各自的“视角/朝向调整”方案，并将原先共用的 max_hit 拆分到任务级节点上，避免多任务之间相互消耗命中次数。
Changes:
- 将原先按方向拆分的
EnvironmentMonitoringTakePhotoUp/Down/Left/Right合并为统一入口EnvironmentMonitoringTakePhoto。 - 在拍照失败回退链路中改为使用锚点
EnvironmentMonitoringAdjustCamera指向“任务专属的调整朝向子任务”。 - 为多个城郊监测终端任务新增各自的
*AdjustCamera子任务节点，并在任务进入拍照前设置对应 anchor。
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/resource/pipeline/EnvironmentMonitoring/TakePhoto.json | 合并拍照入口，并将回退调整逻辑从 EnvironmentMonitoringSwipeScreen* 改为锚点 EnvironmentMonitoringAdjustCamera |
| assets/resource/pipeline/EnvironmentMonitoring/OutskirtsMonitoringTerminal/IndoorCrops.json | 为“室内作物”任务设置 EnvironmentMonitoringAdjustCamera 并新增任务专属调整子任务 |
| assets/resource/pipeline/EnvironmentMonitoring/OutskirtsMonitoringTerminal/EternalSunset.json | 为“栖霞驻影”任务设置 EnvironmentMonitoringAdjustCamera 并新增任务专属调整子任务 |
| assets/resource/pipeline/EnvironmentMonitoring/OutskirtsMonitoringTerminal/CollapsedTianshiPillar.json | 为“天师柱塌陷”任务设置 EnvironmentMonitoringAdjustCamera 并新增任务专属调整子任务 |
| assets/resource/pipeline/EnvironmentMonitoring/OutskirtsMonitoringTerminal/CleansingJade.json | 为“漱玉”任务设置 EnvironmentMonitoringAdjustCamera 并新增任务专属调整子任务 |
| assets/resource/pipeline/EnvironmentMonitoring/OutskirtsMonitoringTerminal/CisternOriginiumSlugs.json | 为“蓄水源石虫”任务设置 EnvironmentMonitoringAdjustCamera 并新增任务专属调整子任务（向右滑） |
| assets/resource/pipeline/EnvironmentMonitoring/OutskirtsMonitoringTerminal/BeaconDamagedInBlightTide.json | 为“侵蚀潮中损坏的信标”任务设置 EnvironmentMonitoringAdjustCamera 并新增任务专属调整子任务（向下滑） |
| assets/resource/pipeline/EnvironmentMonitoring/OutskirtsMonitoringTerminal/AncientTree.json | 为“古树”任务设置 EnvironmentMonitoringAdjustCamera 并新增任务专属调整子任务 |
Comments suppressed due to low confidence (1)
assets/resource/pipeline/EnvironmentMonitoring/TakePhoto.json:7
- 现在 EnterCameraModeClick 的失败分支改为跳转到
[JumpBack][Anchor]EnvironmentMonitoringAdjustCamera，但EnvironmentMonitoringTakePhoto本身不再设置该 anchor；如果调用方未显式设置（例如 OutskirtsMonitoringTerminal/RainbowFin.json 仍直接进入EnvironmentMonitoringTakePhotoDirectly且只设置了EnvironmentMonitoringBactToTerminal），该 [Anchor] 会解析不到目标节点，导致回退流程失败。建议在EnvironmentMonitoringTakePhoto增加一个默认的EnvironmentMonitoringAdjustCameraanchor（指向一个安全的默认调整/空操作节点），并/或确保所有进入拍照流程的任务在进入前都设置该 anchor。
"EnvironmentMonitoringTakePhoto": {
"desc": "环境监测拍照",
"next": [
"EnvironmentMonitoringEnterCameraMode",
"EnvironmentMonitoringTakePhotoDirectly"
]
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
并且不再共用 max_hit ## Summary by Sourcery 支持为每个 EnvironmentMonitoring 任务配置各自独立的视角调整方案，而不再在任务之间共享诸如 `max_hit` 等公共参数。 New Features: - 允许每个 EnvironmentMonitoring 任务在其 JSON 配置中定义自己的相机/视角调整方案。 Enhancements: - 解耦共享的 `max_hit` 及相关参数，使监控任务不再在公共配置中共享视点调优设置。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Support distinct view adjustment configurations per EnvironmentMonitoring task without sharing common parameters like max_hit across tasks. New Features: - Allow each EnvironmentMonitoring mission to define its own camera/view adjustment scheme in its JSON configuration. Enhancements: - Decouple shared max_hit and related parameters so monitoring tasks no longer share viewpoint tuning settings in common configs. </details>
MistEO
pushed a commit
that referenced
this pull request
Mar 9, 2026
并且不再共用 max_hit ## Summary by Sourcery 支持为每个 EnvironmentMonitoring 任务配置各自独立的视角调整方案，而不再在任务之间共享诸如 `max_hit` 等公共参数。 New Features: - 允许每个 EnvironmentMonitoring 任务在其 JSON 配置中定义自己的相机/视角调整方案。 Enhancements: - 解耦共享的 `max_hit` 及相关参数，使监控任务不再在公共配置中共享视点调优设置。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Support distinct view adjustment configurations per EnvironmentMonitoring task without sharing common parameters like max_hit across tasks. New Features: - Allow each EnvironmentMonitoring mission to define its own camera/view adjustment scheme in its JSON configuration. Enhancements: - Decouple shared max_hit and related parameters so monitoring tasks no longer share viewpoint tuning settings in common configs. </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
并且不再共用 max_hit
Summary by Sourcery
支持为每个 EnvironmentMonitoring 任务配置各自独立的视角调整方案，而不再在任务之间共享诸如
max_hit等公共参数。New Features:
Enhancements:
max_hit及相关参数，使监控任务不再在公共配置中共享视点调优设置。Original summary in English
Summary by Sourcery
Support distinct view adjustment configurations per EnvironmentMonitoring task without sharing common parameters like max_hit across tasks.
New Features:
Enhancements: