Merged
Conversation
Contributor
There was a problem hiding this comment.
你好——我已经审查了你的改动,看起来非常棒!
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的代码审查。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 修复基建奖励领取流程中的错误,主要改进了奖励关闭按钮的识别精确度(通过 And 组合识别防止误触),新增了培养舱入口节点 EntryGrowthChamber,重构了恢复心情的流程逻辑,并在关键点位增加了 pre_wait_freezes 以稳定 UI。
Changes:
- 将
CloseRewardsButton从单一模板匹配改为And组合识别(按钮 + 奖励图标),避免在非奖励界面误匹配 - 新增
EntryGrowthChamber节点以从控制中枢直接进入培养舱,并在主流程ControlNexus.next中添加引用 - 重构恢复心情流程:使用
[JumpBack]模式简化RecoveryEmotionAssistUseAssist的调用链,简化 ADB overlay
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| assets/resource_fast/pipeline/Common/Button.json | 将 CloseRewardsButton 改为 And 识别,新增 DectedCloseRewardsButton 和 DectedCloseRewardsImage 辅助节点 |
| assets/resource_fast/image/Common/Button/CloseRewardImage.png | 新增奖励界面头部图标模板图片 |
| assets/resource_adb/pipeline/DijiangRewards/RecoveryEmotion.json | 简化 ADB overlay,仅覆盖 EmotionBar 的 roi_offset |
| assets/resource/pipeline/DijiangRewards/RecoveryEmotion.json | 重构恢复心情流程,使用 JumpBack 模式 |
| assets/resource/pipeline/DijiangRewards/ReceptionRoom.json | 为 SetClues 添加 pre_wait_freezes 稳定 UI |
| assets/resource/pipeline/DijiangRewards/Manufacturing.json | 为 MFGCarbinNeedTakeClose 添加 pre_wait_freezes 稳定 UI |
| assets/resource/pipeline/DijiangRewards/MainFlow.json | 在 ControlNexus.next 中添加 [JumpBack]EntryGrowthChamber |
| assets/resource/pipeline/DijiangRewards/GrowthChamber.json | 新增 EntryGrowthChamber 节点,将 InGrowthChamber 重命名为 BackToGrowthChamber |
Comment on lines
+616
to
+617
| "DectedCloseRewardsButton", | ||
| "DectedCloseRewardsImage" |
There was a problem hiding this comment.
DectedCloseRewardsButton 和 DectedCloseRewardsImage 中的 "Dected" 是 "Detected" 的拼写错误。请将这两个节点名及其在 all_of 列表中的引用统一修正为 DetectedCloseRewardsButton 和 DetectedCloseRewardsImage。
Comment on lines
+638
to
+657
| "DectedCloseRewardsImage": { | ||
| "desc": "检测到奖励界面时的图标", | ||
| "recognition": { | ||
| "type": "TemplateMatch", | ||
| "param": { | ||
| "roi": [ | ||
| 437, | ||
| 0, | ||
| 419, | ||
| 224 | ||
| ], | ||
| "template": [ | ||
| "Common/Button/CloseRewardImage.png" | ||
| ], | ||
| "method": 10001, | ||
| "threshold": 0.9 | ||
| } | ||
| } | ||
| }, | ||
| "DectedCloseRewardsButton": { |
There was a problem hiding this comment.
同上,DectedCloseRewardsImage 和 DectedCloseRewardsButton 节点定义名中的 "Dected" 应改为 "Detected"。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
修复多处地缚(Dijiang)基础设施房间的错误奖励配置,并更新共享按钮资源定义。
Bug 修复:
增强内容:
Original summary in English
Summary by Sourcery
Fix incorrect rewards configuration for multiple Dijiang infrastructure rooms and update a shared button resource definition.
Bug Fixes:
Enhancements: