refactor(SellProduct): 优化货品更换逻辑和文本输出 by he0119 · Pull Request #1033 · MaaEnd/MaaEnd

he0119 · 2026-03-06T04:03:02Z

利用 maxhit 限制换货次数，同时在成功卖出货品之后不再提示 该据点调度券不足，过一会再来吧。

close #871

应该也能修复 fix #681，但是我这里没有测试环境。

Summary by Sourcery

优化 SellProduct 流水线，对商品兑换尝试次数进行上限控制，并在成功销售后避免出现误导性的优惠券不足警告。

Bug Fixes:

修复在 SellProduct 流程中商品成功售出后，仍然出现优惠券不足警告的问题。

Enhancements:

在不同地点的 SellProduct 流水线中，基于 maxhit 对商品兑换尝试次数施加上限限制。

Original summary in English

Summary by Sourcery

Refine SellProduct pipelines to cap product exchange attempts and avoid misleading coupon shortage warnings after successful sales.

Bug Fixes:

Prevent coupon shortage warnings from appearing after a product has been successfully sold in SellProduct flows.

Enhancements:

Apply maxhit-based limits on product exchange attempts across SellProduct pipelines for different locations.

Bug 修复：

防止在商品成功售出后仍然出现“派发优惠券不足”的警告。

功能增强：

在不同地点的 SellProduct 流水线中，通过 maxhit 配置限制商品兑换次数。

Original summary in English

Summary by Sourcery

优化 SellProduct 流水线，对商品兑换尝试次数进行上限控制，并在成功销售后避免出现误导性的优惠券不足警告。

Bug Fixes:

修复在 SellProduct 流程中商品成功售出后，仍然出现优惠券不足警告的问题。

Enhancements:

在不同地点的 SellProduct 流水线中，基于 maxhit 对商品兑换尝试次数施加上限限制。

Original summary in English

Summary by Sourcery

Refine SellProduct pipelines to cap product exchange attempts and avoid misleading coupon shortage warnings after successful sales.

Bug Fixes:

Prevent coupon shortage warnings from appearing after a product has been successfully sold in SellProduct flows.

Enhancements:

Apply maxhit-based limits on product exchange attempts across SellProduct pipelines for different locations.

sourcery-ai

嗨——我已经 review 了你的改动，看起来很棒！

Sourcery 对开源项目是免费的——如果你觉得我们的代码审查有帮助，欢迎分享 ✨

_{帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进之后的代码审查。}

Original comment in English

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

Copilot

Pull request overview

该 PR 针对 SellProduct 售卖流程做重构：通过锚点动态切换“调度券不足”提示节点，并用 max_hit 限制“缺货→更换货品”的触发次数，以实现「成功完成一次交易」后不再输出“该据点调度券不足，过一会再来吧”（close #871）。

Changes:

在 SellCore.json 引入 [Anchor]SellProductZeroMoneyHandler，并新增 SellProductZeroMoneyWithTip，实现“未成交才提示、成交后不提示”的分流。
将“缺货处理”拆分为“先尝试换货（max_hit=1）”与“换货后仍缺货（进入换据点流程）”两个节点，移除 *AfterChange 分支。
在 Wuling.json / ValleyIV.json 的各据点入口设置锚点为 SellProductZeroMoneyWithTip，并在成交确认后将锚点切回无提示版本。

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
assets/resource_fast/pipeline/SellProduct/SellCore.json	核心售卖逻辑重构：缺货换货次数限制、调度券不足提示分流与锚点切换
assets/resource_fast/pipeline/SellProduct/ChangeGoods.json	更换货品确认后回到统一的 `SellProductAtSell` 流程
assets/resource_fast/pipeline/SellProduct/Wuling.json	武陵据点售卖入口设置 `SellProductZeroMoneyHandler` 锚点为带提示版本
assets/resource_fast/pipeline/SellProduct/ValleyIV.json	四号谷地各据点售卖入口设置 `SellProductZeroMoneyHandler` 锚点为带提示版本

assets/resource_fast/pipeline/SellProduct/SellCore.json

fixed #681

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sourcery-ai

嗨，我已经审查了你的改动，一切看起来都很好！

Sourcery 对开源项目是免费的——如果你觉得我们的代码审查有帮助，请考虑分享它们 ✨

_{帮我变得更有用！请对每条评论点 👍 或 👎，我会根据你的反馈改进之后的代码审查。}

Original comment in English

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

利用 maxhit 限制换货次数，同时在成功卖出货品之后不再提示 `该据点调度券不足，过一会再来吧`。 close #871 应该也能修复 fix #681，但是我这里没有测试环境。 ## Summary by Sourcery 优化 SellProduct 流水线，对商品兑换尝试次数进行上限控制，并在成功销售后避免出现误导性的优惠券不足警告。 Bug Fixes: - 修复在 SellProduct 流程中商品成功售出后，仍然出现优惠券不足警告的问题。 Enhancements: - 在不同地点的 SellProduct 流水线中，基于 `maxhit` 对商品兑换尝试次数施加上限限制。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Refine SellProduct pipelines to cap product exchange attempts and avoid misleading coupon shortage warnings after successful sales. Bug Fixes: - Prevent coupon shortage warnings from appearing after a product has been successfully sold in SellProduct flows. Enhancements: - Apply maxhit-based limits on product exchange attempts across SellProduct pipelines for different locations. </details> Bug 修复： - 防止在商品成功售出后仍然出现“派发优惠券不足”的警告。功能增强： - 在不同地点的 SellProduct 流水线中，通过 `maxhit` 配置限制商品兑换次数。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery 优化 SellProduct 流水线，对商品兑换尝试次数进行上限控制，并在成功销售后避免出现误导性的优惠券不足警告。 Bug Fixes: - 修复在 SellProduct 流程中商品成功售出后，仍然出现优惠券不足警告的问题。 Enhancements: - 在不同地点的 SellProduct 流水线中，基于 `maxhit` 对商品兑换尝试次数施加上限限制。 <details> <summary>Original summary in English</summary> ## Summary by Sourcery Refine SellProduct pipelines to cap product exchange attempts and avoid misleading coupon shortage warnings after successful sales. Bug Fixes: - Prevent coupon shortage warnings from appearing after a product has been successfully sold in SellProduct flows. Enhancements: - Apply maxhit-based limits on product exchange attempts across SellProduct pipelines for different locations. </details> </details> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

he0119 added 2 commits March 6, 2026 11:41

refactor(SellProduct): 优化货品更换逻辑，简化流程

5ecd2ad

refactor(SellProduct): 更新货品售卖逻辑，添加缺少调度券提示

7b029c5

Copilot AI review requested due to automatic review settings March 6, 2026 04:03

sourcery-ai bot reviewed Mar 6, 2026

View reviewed changes

Copilot started reviewing on behalf of he0119 March 6, 2026 04:03 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

assets/resource_fast/pipeline/SellProduct/SellCore.json Outdated Show resolved Hide resolved

assets/resource_fast/pipeline/SellProduct/SellCore.json Outdated Show resolved Hide resolved

he0119 marked this pull request as draft March 6, 2026 05:27

he0119 and others added 3 commits March 6, 2026 13:28

fix(SellProduct): 如果需要选择交易货品时，尝试更换一次货品

457c789

fixed #681

Update assets/resource_fast/pipeline/SellProduct/SellCore.json

21e596c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: 每个据点单独尝试更换一次货品

941a7df

he0119 marked this pull request as ready for review March 6, 2026 06:11

sourcery-ai bot reviewed Mar 6, 2026

View reviewed changes

he0119 merged commit ceb060d into main Mar 6, 2026
17 checks passed

he0119 deleted the refactor/sell-product-retry branch March 6, 2026 07:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(SellProduct): 优化货品更换逻辑和文本输出#1033

refactor(SellProduct): 优化货品更换逻辑和文本输出#1033
he0119 merged 5 commits intomainfrom
refactor/sell-product-retry

he0119 commented Mar 6, 2026 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

he0119 commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Summary by Sourcery

Summary by Sourcery

Summary by Sourcery

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

he0119 commented Mar 6, 2026 •

edited

Loading