Skip to content

configure: fix Qt parameter parsing for MacOS#2525

Merged
jdtournier merged 2 commits intodevfrom
fix_configure_qt_macos
Nov 21, 2022
Merged

configure: fix Qt parameter parsing for MacOS#2525
jdtournier merged 2 commits intodevfrom
fix_configure_qt_macos

Conversation

@jdtournier
Copy link
Copy Markdown
Member

Fix detection of parameters for compiling with Qt on macOS. Requires testing on other platforms...

@jdtournier jdtournier added this to the 3.0.4 milestone Nov 17, 2022
@jdtournier jdtournier requested review from a team and bjeurissen November 17, 2022 13:49
@jdtournier jdtournier self-assigned this Nov 17, 2022
Copy link
Copy Markdown
Member

@bjeurissen bjeurissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me (on Mac)!

@jdtournier
Copy link
Copy Markdown
Member Author

Doesn't work for me on Linux...

@jdtournier
Copy link
Copy Markdown
Member Author

OK, works with that last commit. That will also need double-checking on macOS and MSYS2.

@Lestropie
Copy link
Copy Markdown
Member

Tested OK on MSYS2.

@Lestropie Lestropie added the gui label Nov 20, 2022
@bjeurissen
Copy link
Copy Markdown
Member

bjeurissen commented Nov 21, 2022

On macOS, works with Qt5, but fails with Qt6 (due to -std=c++11 being used regardless of Qt version). The Qt6 fail is expected as this PR does not address Qt6 yet, so I guess it is good to merge.

@jdtournier jdtournier merged commit 5344631 into dev Nov 21, 2022
@jdtournier jdtournier deleted the fix_configure_qt_macos branch November 21, 2022 10:22
jdtournier added a commit that referenced this pull request Dec 6, 2022
configure: fix Qt parameter parsing for MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants