CohortDataImport::initialise(): Fix for cwd#2057
Merged
jdtournier merged 1 commit intomasterfrom May 17, 2020
Merged
Conversation
Empty string output by Path::dirmane() if the location of the list file is the current working directory would lead to an erroneous Exception being thrown, as that string being empty is also used as a flag to indicate that none of the candidate directories were reliable references for finding all subject files. This fix uses "." rather than "" for the current working directory, so that if a valid Exception is indeed thrown the error message should make more sense.
jdtournier
approved these changes
May 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue reported on forum.
Fixes issue where an exception is erroneously thrown when the subject filename list resides in the current working directory, and no template directory is defined.
Error arising from #1977.
It is possible to bypass the issue by simply prepending the path to the subject file list with "
./"; nevertheless targeting atmastersince it's a bug.