Conversation
Loading statistical inference cohort data could lead to issues if the text file containing the subject file list resided in a different directory. fixelcfestats was unique in that it would also look for those files relative to the input fixel directory; but this would not work if the subject list text file was not in the current working directory, as the directory of that file was erroneously added to the file basename prior to Path::join(). In this change, the potential utilisation of different base directories in order to find the input data is generalised and moved to CohortDataImport::initialise(). For most commands, locating all input files is first tested relative to the location of the subjects test file, then the current working directory. In the case of fixelcfestats, the input fixel directory tested before either of these two. Only if all input files are found on the filesystem for a given directory location is the import of data from those files attempted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue raised in #1543. More details in commit message.
Tested as working in the case where the text file listing all input files for statistical inference resides in a directory that is neither the input fixel directory nor the current working directory.