Update dwi2response dhollander#1545
Merged
thijsdhollander merged 50 commits intoscript_changesfrom Feb 5, 2019
Merged
Conversation
…uring development (will eventually again become a single dhollander algo though, if dhollander_new performs to expectations)
…experiments. Just to record this in the commit history for convenience. Eventually, dhollander_old and dhollander_new will dissappear again; dhollander_new will become dhollander.
Contributor
Author
|
Alright, all checked and done. I'll merge this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to
dwi2response dhollanderalgorithm and user interface (not the arguments/options, only what information appears on the terminal as feedback for the user).@Lestropie : I've created this pull request against the
script_changesbranch for convenience. It's entirely up to date withscript_changesand thus uses the new API throughout. I've also manually checked that those API changes don't break my intended behaviour (as I had finished most of these changes before the new API, and later on merged the API in), similar to how I believe you've manually checked outputs for other scripts before/afterscript_changes's impact.Don't merge yet; I still have to have a final check, and update some documentation.