Python fsl.findimage() function#1080
Conversation
This helper function should be used to locate output images from FSL commands, due to the fact that not all FSL commands / software versions honour the FSLOUTPUTTYPE environment variable.
Unfortunately only works in the absence of SGE; to fix this issue with SGE would require modifying the file.waitFor() function to accept a list of paths, and repeately check to see if _any_ of those paths exist.
|
I've successfully executed all scripts affected by these changes. I also made a bad boo-boo in #1047 here: Because Open to review... Any volunteers? |
|
Not sure I'm the best person to be reviewing this... I'm happy for it to be merged if you're 'happy' with it. As you say, this is the kind to things that requires extensive community testing to really identify all the edge cases. It would be good to have tests for all of these, but that will be a lot of work, and definitely won't make it into |
thijsdhollander
left a comment
There was a problem hiding this comment.
Looks good, but agree with @jdtournier that we'll need to get "community debugging" for these things. Hence, I'd encourage the merge even more. And of course to fix -rpe_none and -rpe_pair... we can't have those being broken; they're the most frequently used scenarios, I reckon.
Another script fix necessary to get through my test of #1077.