Skip to content

dwipreproc: Fix volume matching with zero-length gradient vectors#1077

Merged
Lestropie merged 1 commit intotag_3.0_RC2from
dwipreproc_volmatch_zerovec_fix
Aug 3, 2017
Merged

dwipreproc: Fix volume matching with zero-length gradient vectors#1077
Lestropie merged 1 commit intotag_3.0_RC2from
dwipreproc_volmatch_zerovec_fix

Conversation

@Lestropie
Copy link
Copy Markdown
Member

@Lestropie Lestropie commented Aug 2, 2017 •
edited
Loading

As raised here.

Edit: Will wait overnight to make sure the test with the provided data passes.

@Lestropie Lestropie self-assigned this Aug 2, 2017
thijsdhollander
thijsdhollander approved these changes Aug 2, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@thijsdhollander thijsdhollander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it here, but it seems to make sense to address the problem with the zero-norm b=0 vectors. The extra optional debug messages/outputs should be helpful too for people to get insight into what's going on (if they require it).

@Lestropie
Copy link
Copy Markdown
Member Author

Lestropie commented Aug 3, 2017

While my test failed, it was for a different reason (similar issue previously encountered & solved here):

$ echo $FSLOUTPUTTYPE
NIFTI
$ fsl5.0-applytopup --imain=dwi_pe_1.nii --datain=applytopup_config.txt --inindex=1 --topup=field --out=dwi_pe_1_topup.nii --method=jac
$ mrconvert dwi_pe_1_topup.nii dwi_pe_1_topup.mif -json_import dwi_pe_1.json
mrconvert: [ERROR] cannot stat file "dwi_pe_1_topup.nii": No such file or directory
$ ls
dwi_pe_1_topup.nii.gz

🤕

@Lestropie Lestropie merged commit 9039443 into tag_3.0_RC2 Aug 3, 2017
@Lestropie Lestropie deleted the dwipreproc_volmatch_zerovec_fix branch August 3, 2017 10:31
@Lestropie Lestropie mentioned this pull request Aug 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thijsdhollander thijsdhollander thijsdhollander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Lestropie Lestropie

Labels

bug scripts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lestropie @thijsdhollander