Add validation for Carb Entry Absorption time (less than 999)#96
Merged
Conversation
Collaborator
|
I can see it popping up a window to suggest < 999 minutes for CA when I enter large values, but when I do enter a valid value, it doesn't seem to be saving. |
Contributor
Author
|
Fixed. There is code checking the sender of the Unwind Segue. If it's not the SaveButton it's assumed to be a Cancel. |
798eb61 to
a19da7b
Compare
ps2
pushed a commit
that referenced
this pull request
Aug 4, 2020
- https://tidepool.atlassian.net/browse/LOOP-1144 - Move StoredDosingDecision Codable from LoopKit to Loop to support error serialization - Update DosingDecisionStore to store and retrieve generalized data - Update decoding of optional properties to use decodeIfPresent - Use static encoder and decoder for StoredSettings - Add additional remote data service logging in MockService - Update coding tests to check intermediate serialized data string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't allow absorption time entries over 999. Basic validation from the Carb Entry Edit VC.
LoopKit/Loop#312
@ps2