Turn on whole module optimization, as recommended by Xcode#91
Merged
Conversation
Author
|
apparently this can cause crashes in Loop due to symbols being incorrectly optimized away. Hold off on pulling this until I can do an end-to-end test. |
Author
|
ok - I've run through the basics on the app and found/fixed the one issue where the optimization was getting rid of a reachable path. I'll file a bug against Apple for that issue but in the meantime I think this is ready to merge. We should get it into the dev branch of Loop ASAP to get more eyes on it. |
loudnate
approved these changes
Jan 2, 2017
ddaniels1
pushed a commit
to ddaniels1/LoopKit
that referenced
this pull request
Apr 2, 2018
Leveraging protocols to simplify multiple sources of glucose
ps2
pushed a commit
that referenced
this pull request
May 12, 2020
…undVendor, add to clients (#91) * Remove default implementations of DeviceAlertResponder, DeviceAlertSoundVendor, add to clients * fix merge issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.