Revert pumpevent fix attempt#577
Merged
Merged
Conversation
Contributor
TestTest Steps DefinitionThe most reliable test for this issue is:
ConfigurationBegin with release/3.8.2, commit
Test 1Modify LoopKit to
Test 2Step back 1 commit in LoopKit (to
Future stepsOnce pump managers do not trigger this error, then the fatal error, if it happens, can be added back to assist in identifying this issue for any future new pump managers. |
marionbarker
approved these changes
Oct 31, 2025
marionbarker
left a comment
Contributor
There was a problem hiding this comment.
Approved from code review and test.
LGTM
Jon-b-m
added a commit
to Artificial-Pancreas/iAPS
that referenced
this pull request
Nov 14, 2025
This was referenced Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifying the events pumpmanagers report was hack to try to deal with invalid events. Fixing the pumpmanagers is a better solution. The pumpmanagers that were reporting the invalid events are removed from the main code now.
Adding a fatalError if invalid pump events are submitted, so pumpmanager developers will discover issues like this faster.