Update LoopKit tidepool-merge with improvements from dev#560
Merged
Conversation
* improve the visibility of the options to select * modify color and lineWidth
* fix LoopKit/Loop#2223 accept comma in carb entry Signed-off-by: Jörg Schömer <joerg@joerg-schoemer.de> * Remove debug print statements. --------- Signed-off-by: Jörg Schömer <joerg@joerg-schoemer.de> Co-authored-by: Pete Schwamb <pete@schwamb.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Bring in improvements added to the dev branch since the tidepool-merge branch was first pushed to LoopKit
Test
Start with a local clone using LoopWorkspace
tidepool-mergebranch:Confirm the checkmark limit is easy to see and Carb input accepts comma as a decimal separator so long as the leading zero is typed.
The issue pointed out in Loop 2307 is still present but will be corrected in a separate PR.