fix LoopKit/Loop#2223#546
Merged
Merged
Conversation
accept comma in carb entry Signed-off-by: Jörg Schömer <joerg@joerg-schoemer.de>
Contributor
Author
|
Hi @SwiftlyNoah could you please review this little change to get the decimal separator back to work on different locales. |
ps2
requested changes
Oct 5, 2024
ps2
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me generally. Please remove the debug prints.
Contributor
|
I set my test phone location to Germany (to enable the "," on the keypad) and Loop language to German and confirmed the problem reported in Loop Issue 2223. I built with this modification onto the same phone.
|
marionbarker
pushed a commit
to loopandlearn/LoopKit
that referenced
this pull request
Oct 28, 2024
loopkitdev
pushed a commit
to loopkitdev/LoopKit
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accept comma in carb entry