Insulin Correction Safety and Fixes#545
Closed
motinis wants to merge 1 commit into
Closed
Conversation
Collaborator
|
I think this might be covered in the LoopAlgorithm package, which will be landing soon in dev. |
Author
|
@ps2 looking through the LoopAlgorithm source code I think these changes are still relevant - would you prefer I open a PR against that repo instead? Or you want to merge that to dev first and then look at this PR? |
marionbarker
pushed a commit
to loopandlearn/LoopKit
that referenced
this pull request
Oct 28, 2024
…ent-store LOOP-4735 CGM Event Store
loopkitdev
pushed a commit
to loopkitdev/LoopKit
that referenced
this pull request
Mar 12, 2026
…ent-store LOOP-4735 CGM Event Store
Collaborator
|
The main part of this ticket (effectedSensitivity calculation) was fixed a while ago. The second part is maybe not possible to hit. If you can construct a realistic situation where that change is needed, please update this PR with the test (or create a new one against LoopAlgorithm, more likely) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see discussion in zulipchat.
This PR covers two important points: