Add Siri support for overrides#343
Conversation
…egra/add-override-history
| public let enactTrigger: EnactTrigger | ||
| public let syncIdentifier: UUID | ||
|
|
||
| public var actualEnd: End = .natural |
There was a problem hiding this comment.
I moved this logic out of TemporayScheduleOverrideHistory and into here so the history screens can have access to it
There was a problem hiding this comment.
Can OverrideEvent be cleaned up to not need this then, since OverrideEvent contains a TemporaryScheduleOverride?
| @nonobjc static let lightenedInsulin = BundleColor("Lightened Insulin") ?? systemOrange | ||
|
|
||
| @nonobjc static let darkenedInsulin = BundleColor("Darkened Insulin") ?? systemOrange | ||
|
|
There was a problem hiding this comment.
Colors for override percentage gauge bar
There was a problem hiding this comment.
Colors used in LoopKit should be provided by the app layer in some way. Passing colors into the view constructor, or assigning attributes on the view, or setting up Environment attributes for SwiftUI views.
ps2
left a comment
There was a problem hiding this comment.
Generally looks good code wise; colors should not be pulling from the LoopKit bundle, though. I haven't run it yet, but just looked at the code.
| @nonobjc static let lightenedInsulin = BundleColor("Lightened Insulin") ?? systemOrange | ||
|
|
||
| @nonobjc static let darkenedInsulin = BundleColor("Darkened Insulin") ?? systemOrange | ||
|
|
There was a problem hiding this comment.
Colors used in LoopKit should be provided by the app layer in some way. Passing colors into the view constructor, or assigning attributes on the view, or setting up Environment attributes for SwiftUI views.
| public let enactTrigger: EnactTrigger | ||
| public let syncIdentifier: UUID | ||
|
|
||
| public var actualEnd: End = .natural |
There was a problem hiding this comment.
Can OverrideEvent be cleaned up to not need this then, since OverrideEvent contains a TemporaryScheduleOverride?
…eginning (#343) - https://tidepool.atlassian.net/browse/LOOP-2554 - Add RawRepresentable conformance to TherapySettings
Currently, overrides aren't visible to Siri (meaning they can't be set with Shortcuts or via voice). There also isn't a great way to view the override history in Loop; the issue report does contain the history, but it's not in a very human-readable format.
This PR: