Skip to content

LoopKit tweaks#129

Merged
ps2 merged 1 commit into
devfrom
loopkit-tweaks
May 20, 2017
Merged

LoopKit tweaks#129
ps2 merged 1 commit into
devfrom
loopkit-tweaks

Conversation

@ps2

@ps2 ps2 commented May 19, 2017

Copy link
Copy Markdown
Collaborator
  • Deprecates CarbStore methods relying on implicit start date and opaque caching (Supporting more insulin action durations. DoseStore test coverage #10)
  • Re-enables deletion in the insulin delivery table view controller
  • Other documentation and naming cleanup:
    • Removes more duplicative "Handler" naming for closures
    • Minor breaking naming change for CarbStoreSyncDelegate. Intentional as there aren't easy ways to deprecate non-objc protocol methods
    • Minor clarity tweaks in DoseStore prime checking
  • Improves logic for computing glucose changes over a period of time that includes calibrations

…que caching (#10)

- Re-enables deletion in the insulin delivery table view controller
- Other documentation and naming cleanup:
    - Removes more duplicative "Handler" naming for closures
    - Minor breaking naming change for CarbStoreSyncDelegate. Intentional as there aren't easy ways to deprecate non-objc protocol methods
    - Minor clarity tweaks in DoseStore prime checking
- Improves logic for computing glucose changes over a period of time that includes calibrations
@ps2 ps2 changed the title - Deprecates CarbStore methods relying on implicit start date and opa… LoopKit tweaks May 19, 2017
@ps2 ps2 merged commit f906bde into dev May 20, 2017
@ps2 ps2 deleted the loopkit-tweaks branch May 24, 2017 01:39
ddaniels1 pushed a commit to ddaniels1/LoopKit that referenced this pull request Apr 2, 2018
Updating Amplitude framework to 3.8.4
ps2 pushed a commit that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant