Skip to content

Show version on settings page as top section header#82

Merged
loudnate merged 1 commit into
LoopKit:devfrom
ps2:show-version
Jul 22, 2016
Merged

Show version on settings page as top section header#82
loudnate merged 1 commit into
LoopKit:devfrom
ps2:show-version

Conversation

@ps2

@ps2 ps2 commented Jul 21, 2016

Copy link
Copy Markdown
Collaborator

No description provided.

case .Loop:
return nil
let version = NSBundle.mainBundle().objectForInfoDictionaryKey("CFBundleShortVersionString")!
return "Loop iOS v\(version)"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NSLocalizedString, please!

@loudnate loudnate merged commit 9aa09ca into LoopKit:dev Jul 22, 2016
@ps2 ps2 deleted the show-version branch August 7, 2016 17:08
erikdi pushed a commit to erikdi/Loop that referenced this pull request Feb 10, 2019
* Observe backfill messages

* Add glucoseHistoryTx back in.  Update example app.
ps2 pushed a commit that referenced this pull request Aug 4, 2020
* Always send updated WatchContext

* Prevent updates after sending confirmation message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants