Spir-v: just gate the Display impl instead#69
Merged
Lokathor merged 1 commit intoLokathor:mainfrom Jun 13, 2021
Merged
Conversation
The old version didn't compile (because of the extra semicolon)
Owner
|
reasonable, and this can be "undone" later if necessary by making the impl be everywhere with conditional compilation moving back inside. |
Contributor
Author
|
Yeah, exactly. Moving the strange behaviour to compile time is useful. |
Owner
|
released as 1.6.3 |
DJMcNab
added a commit
to DJMcNab/rust-gpu
that referenced
this pull request
Jun 13, 2021
Lokathor/bytemuck#69 landed That version also works 🎉
DJMcNab
added a commit
to DJMcNab/compute-shader-101
that referenced
this pull request
Jun 13, 2021
as of Lokathor/bytemuck#69 No longer depend on it conditionally
khyperia
pushed a commit
to EmbarkStudios/rust-gpu
that referenced
this pull request
Jun 14, 2021
* Use bytemuck for the push constants * Use the released version of bytemuck Lokathor/bytemuck#69 landed That version also works 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old version didn't compile (because of the extra semicolon).
It is extremely unlikely that anyone would ever want to use this impl on gpu, at least whilst the compiler is in its current state - if the impls did start working, they could just use the
Debugimpl.This is not a breaking change, since all prior versions didn't compile on spir-v anyway.
As a small note, there is no expectation for you to proactively support the spir-v target; beyond checking PRs which fixup any breakage - bytemuck stopping compiling would be the least breaking change in the entire rust-gpu ecosystem.