Conversation
NicholasLin718
commented
Mar 5, 2023
- Implemented new API instance manifest integration to dynamically generate forms based on the sections provided by the manifest
- Added a new sidebar and select game instance page + styling
…e-Team/dashboard into new-setup-dynamic-forms
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ynng
left a comment
There was a problem hiding this comment.
A few more things not mentioned in the comments:
-
Currently no minecraft instance is created for me.
When I click "createInstance", pretty much nothing happens. From devtools I can see the validation requests being made but not the creation request. -
Would be nice to remove the console logs after we are done with it
src-tauri/Cargo.toml
Outdated
| tauri-plugin-localhost = "0.1.0" | ||
| portpicker = "0.1" | ||
| lodestone_core = {git = "https://github.com/Lodestone-Team/lodestone_core", branch = "main"} | ||
| lodestone_core = {git = "https://github.com/Lodestone-Team/lodestone_core", branch = "dev/refactor-setup"} |
There was a problem hiding this comment.
We should probably change this to release/0.4.3, and backend should merge dev/refactor-setup in to 0.4.3 @CheatCod
…e-Team/dashboard into new-setup-dynamic-forms
New dynamic settings
Ynng
left a comment
There was a problem hiding this comment.
looks good, works great!
Can we hard code the MOTD editor for the MOTD box though?
What it looked like in previous versions:
What it looks like now:
…ent for radio fields
…nto new-setup-dynamic-forms
Setup form styling - new input fields