New dynamic settings [Merge this before "New setup dynamic forms"]#189
Merged
NicholasLin718 merged 7 commits intonew-setup-dynamic-formsfrom Mar 10, 2023
Merged
New dynamic settings [Merge this before "New setup dynamic forms"]#189NicholasLin718 merged 7 commits intonew-setup-dynamic-formsfrom
NicholasLin718 merged 7 commits intonew-setup-dynamic-formsfrom
Conversation
Contributor
NicholasLin718
commented
Mar 10, 2023
- Dynamically generated objects to be mapped as Setting Fields using the configurable manifest fetched
- Added float validation
- Removed useGameSettings -> Replaced by retrieving all data from configurable manifest
Ynng
approved these changes
Mar 10, 2023
Member
Ynng
left a comment
There was a problem hiding this comment.
netlify bot didn't trigger :( but code looks about right
I'll take another look in the dynamic-form pr once this is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.