Skip to content

Update overview page top section#175

Merged
ViridianCitrus merged 9 commits into0.4.3from
146-new-overview-page-top-section
Feb 25, 2023
Merged

Update overview page top section#175
ViridianCitrus merged 9 commits into0.4.3from
146-new-overview-page-top-section

Conversation

@ViridianCitrus
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit caf5b19
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/63fa6f46a95306000725549c
😎 Deploy Preview https://deploy-preview-175--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit caf5b19
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/63fa6f46e0c31d0008468f75
😎 Deploy Preview https://deploy-preview-175--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ViridianCitrus ViridianCitrus self-assigned this Feb 24, 2023
@ViridianCitrus ViridianCitrus added this to the 0.4.3 milestone Feb 24, 2023
@ViridianCitrus ViridianCitrus requested a review from Ynng February 25, 2023 04:15
@ViridianCitrus ViridianCitrus marked this pull request as ready for review February 25, 2023 04:15
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
tl;dr: copy ip button looks weird

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get rid of the two non breaking space    too, they are messing with the spacing

@ViridianCitrus ViridianCitrus requested a review from Ynng February 25, 2023 20:28
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ViridianCitrus ViridianCitrus merged commit 851cfac into 0.4.3 Feb 25, 2023
@ViridianCitrus ViridianCitrus deleted the 146-new-overview-page-top-section branch February 25, 2023 21:37
Ynng pushed a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants