Skip to content

Code cleaning after classification refactor 3/n#1254

Closed
SkafteNicki wants to merge 5 commits intomasterfrom
cleanup/3
Closed

Code cleaning after classification refactor 3/n#1254
SkafteNicki wants to merge 5 commits intomasterfrom
cleanup/3

Conversation

@SkafteNicki
Copy link
Copy Markdown
Collaborator

@SkafteNicki SkafteNicki commented Oct 6, 2022

What does this PR do?

Follow up to:

Cleaning after the classification refactor.
This PR cleans the modular classification metrics.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the refactoring refactoring and code health label Oct 6, 2022
@SkafteNicki SkafteNicki added this to the v0.11 milestone Oct 6, 2022
@Borda
Copy link
Copy Markdown
Collaborator

Borda commented Oct 31, 2022

So you say we are merging 2+3 together?

@SkafteNicki SkafteNicki deleted the cleanup/3 branch May 10, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring refactoring and code health

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants