Conversation
4 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
========================================
- Coverage 86% 49% -36%
========================================
Files 195 190 -5
Lines 11378 11108 -270
========================================
- Hits 9754 5480 -4274
- Misses 1624 5628 +4004 |
4 tasks
justusschock
approved these changes
Oct 8, 2022
Borda
reviewed
Oct 10, 2022
Borda
requested changes
Oct 11, 2022
Borda
reviewed
Oct 11, 2022
Borda
reviewed
Oct 11, 2022
Borda
reviewed
Oct 11, 2022
Borda
approved these changes
Oct 11, 2022
Collaborator
|
not sure why make docs complains about types :( |
Collaborator
Author
Docs were failing because I had removed this file https://github.com/Lightning-AI/metrics/blob/eacfd2fcd4521fb3c69bcb53e5b1be9117c8a163/docs/source/pages/classification.rst and not all the links to that file. The info in that file is old and in the two follow up PRs I will redo the docstrings of all the old metrics so it matches the new interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cleaning after the classification refactor.
This PR cleans metrics that were directly removed, move to other domain or included in some other metric.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃