Reset val_dataloader in tuner/batch_size_scaling for binsearch#9975
Merged
rohitgr7 merged 1 commit intoLightning-AI:masterfrom Oct 18, 2021
Merged
Reset val_dataloader in tuner/batch_size_scaling for binsearch#9975rohitgr7 merged 1 commit intoLightning-AI:masterfrom
val_dataloader in tuner/batch_size_scaling for binsearch#9975rohitgr7 merged 1 commit intoLightning-AI:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9975 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 179 179
Lines 15839 15840 +1
=======================================
- Hits 14679 14059 -620
- Misses 1160 1781 +621 |
rohitgr7
approved these changes
Oct 17, 2021
Contributor
rohitgr7
left a comment
There was a problem hiding this comment.
Thanks! Totally missed that.
carmocca
approved these changes
Oct 18, 2021
awaelchli
approved these changes
Oct 18, 2021
rohitgr7
pushed a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#9857 fixed the issue for
power, so this is the fix also forbinsearchFixes #9832
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃