Skip to content

Fixed use of LightningCLI in computer_vision_fine_tuning.py example#9934

Merged
carmocca merged 1 commit intoLightning-AI:masterfrom
mauvilsa:fix-example-computer-vision-fine-tuning
Oct 16, 2021
Merged

Fixed use of LightningCLI in computer_vision_fine_tuning.py example#9934
carmocca merged 1 commit intoLightning-AI:masterfrom
mauvilsa:fix-example-computer-vision-fine-tuning

Conversation

@mauvilsa
Copy link
Copy Markdown
Contributor

@mauvilsa mauvilsa commented Oct 14, 2021 •
edited by carmocca
Loading

What does this PR do?

Fixes #9922

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@mauvilsa mauvilsa marked this pull request as ready for review October 14, 2021 19:36
@mauvilsa mauvilsa mentioned this pull request Oct 14, 2021
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2021

Codecov Report

Merging #9934 (9262106) into master (6feda08) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9934    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15805   15805            
=======================================
- Hits        14648   14027   -621     
- Misses       1157    1778   +621

carmocca
carmocca approved these changes Oct 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@carmocca carmocca added this to the v1.5 milestone Oct 14, 2021
@carmocca carmocca added bug Something isn't working argparse (removed) Related to argument parsing (argparse, Hydra, ...) example labels Oct 14, 2021
@carmocca carmocca enabled auto-merge (squash) October 14, 2021 20:17
@mergify mergify bot added the ready to be merged PRs ready to be merged label Oct 14, 2021
@shamanez
Copy link
Copy Markdown

shamanez commented Oct 14, 2021

@mauvilsa

Everything is working except in the this line. My PL version is 1.4.9. Did you install from sources ? I tested my installation with both pip and conda which still gave me the same error.

"KeyError: 'No action for destination key "trainer.enable_model_summary" to set its default.'"

@shamanez
Copy link
Copy Markdown

shamanez commented Oct 14, 2021

Update:

It worked when I install PL from the sources (Version: 1.5.0rc0).

@mauvilsa
Copy link
Copy Markdown
Contributor Author

mauvilsa commented Oct 16, 2021

@shamanez

Everything is working except in the this line.

From what I see the enable_model_summary is a trainer parameter that is being introduced in 1.5.0 and maybe was added by mistake to the computer_vision_fin_tuning.py example in 1.4.X. Anyway just removing that line the example should work without any issue in 1.4.X.

By the way to install 1.5.0rc0 it is not necessary to do it from source. You could do pip install --pre --upgrade pytorch-lightning or pip install pytorch-lightning==1.5.0rc0.

tchaton
tchaton approved these changes Oct 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@carmocca carmocca merged commit 1f09cf2 into Lightning-AI:master Oct 16, 2021
@mauvilsa mauvilsa deleted the fix-example-computer-vision-fine-tuning branch October 16, 2021 16:07
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
@mauvilsa @rohitgr7
Fixed use of LightningCLI in computer_vision_fine_tuning.py example (L…
bca1b66 
…ightning-AI#9934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@Borda Borda Awaiting requested review from Borda

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

+2 more reviewers

@carmocca carmocca carmocca approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

argparse (removed) Related to argument parsing (argparse, Hydra, ...) bug Something isn't working example ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.5

Development

Successfully merging this pull request may close these issues.

Error in computer_vision_fine_tuning.py example

5 participants

@mauvilsa @shamanez @carmocca @tchaton @kaushikb11