Fix logic to check for spawn in worker_check#9902
Merged
Conversation
four4fish
reviewed
Oct 14, 2021
16 tasks
Contributor
Author
|
the issue for failing test is that it's now actually running spawn process and we need to catch some warnings. have tried everything, but couldn't find a way.. feel free to commit.. any help would be appreciated :) thank you |
c9531f8 to
00a93f9
Compare
Contributor
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Codecov Report
@@ Coverage Diff @@
## master #9902 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 179 179
Lines 15839 15825 -14
======================================
- Hits 14679 14661 -18
- Misses 1160 1164 +4 |
kaushikb11
approved these changes
Oct 18, 2021
carmocca
approved these changes
Oct 18, 2021
rohitgr7
added a commit
to Tshimanga/pytorch-lightning
that referenced
this pull request
Oct 18, 2021
* fix * update tests * chlog * skip windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checking for spawn using this
using_spawn = self.accelerator_connector.distributed_backend == "ddp_spawn"isn'tcorrect here because we turn of spawn if
num_processes < 2which is the case the test was running on and was still raising the warning which it shouldn't:https://github.com/PyTorchLightning/pytorch-lightning/blob/4610fddb19d502e534b5c5d77c3dfd6f2e5359a5/pytorch_lightning/trainer/connectors/accelerator_connector.py#L790-L800
this PR just fixes that
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃